-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shortest edge collapse app using a preliminary cuCollections priority queue #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently includes simple functionality to demonstrate bulk build and pop via host interface.
Currently adds the pair<edge_length, local_edge_id> using the priority queue device-side api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds a new application, SECPriority, based on the existing ShortestEdgeCollapse application. This new app replaces the histogram with a preliminary (long standing PR request NVIDIA/cuCollections#105) cuCollections-based priority queue implementation.
Limitation:
The priority queue uses the following pair type <priority, unique_edge_id>:
using PriorityPair_t = cuco::pair<float, uint32_t>;
where the unique_edge_id is limited to 32 bits, versus the general 64 bit encoding across other applications. This is fine for this proof of concept implementation, but limits the size of meshes to 2^16 patches (roughly 30 million triangles). We did this as a workaround due to a CUDA memory alignment issue when using a 64 bit unique_edge_id. We have not yet found the cause of this issue.