-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic growth of slab pool for concurrent_map #22
Open
Nicolas-Iskos
wants to merge
61
commits into
owensgroup:master
Choose a base branch
from
Nicolas-Iskos:resize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved some device allocations in gpu_hash_table for testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications were made to SlabHash's
concurrent_map
as well as SlabAlloc to support dynamic growth of the device-side pool allocator used to extend slab lists.In the SlabHash implementation currently available on the
master
branch, the number of slabs in the device-side slab pool is fixed (to 1GB). Consequently, the total memory footprint of the slab hash is fixed during run time. The code in this PR allows the number of slabs in the pool to increase dynamically during run time. Specifically,ConcurrentMap
'sbuildBulk
andbuildBulkWithUniqueKeys
determine whether the upcoming insertion batch will cause the structure to exceed a user-configurable threshold load factor. If so, new super blocks are added to the slab pool viacudaMalloc
such that the structure's total memory footprint (sum of sizes of the base slabs and slab pool) doubles. Insertion then proceeds as normal. This allows the slab hash to continually grow its total memory footprint until device memory is exhausted.gpu_hash_table
has 3 new parameters (with default values). First, there are two template parameters for the number of memory blocks and number of super blocks with which to initialize the SlabAlloc, allowing the user to configure the initial size of the slab pool. Next, there is a threshold load factor argument which allows the user to configure how much of the SlabHash's total memory footprint can be occupied by key-value pairs before the slab pool is grown to double the total memory footprint.