feat: add session labels on connection metrics #202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to differenciate multiple running upterm host sessions via the metrics endpoint, new metrics will get the session_id label and a custom label.
This is an initial implementation to get a technical breakthrough to see how/if the desired feature request #194 could look like.
The current implementation will generate the following new metrics:
following
upterm host
commands are run to generate the metrics:the
os.getHostname
will be used as custom labelTo be discussed:
upterm_uptermd_routing_active_connections_count
andupterm_uptermd_routing_connections_count