✨ (discrete bar) remove vertical grid lines

owid · Sep 18, 2024 · 4c9bde9 · 4c9bde9
1 parent cea9233
commit 4c9bde9
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 24 deletions.
diff --git a/packages/@ourworldindata/grapher/src/barCharts/DiscreteBarChart.tsx b/packages/@ourworldindata/grapher/src/barCharts/DiscreteBarChart.tsx
@@ -450,19 +450,21 @@ export class DiscreteBarChart
                     <HorizontalNumericColorLegend manager={this} />
                 )}
                 {this.showHorizontalAxis && (
-                    <HorizontalAxisComponent
-                        bounds={boundsWithoutColorLegend}
-                        axis={yAxis}
-                        preferredAxisPosition={innerBounds.bottom}
-                        labelColor={manager.secondaryColorInStaticCharts}
-                        tickMarkWidth={axisLineWidth}
-                    />
+                    <>
+                        <HorizontalAxisComponent
+                            bounds={boundsWithoutColorLegend}
+                            axis={yAxis}
+                            preferredAxisPosition={innerBounds.bottom}
+                            labelColor={manager.secondaryColorInStaticCharts}
+                            tickMarkWidth={axisLineWidth}
+                        />
+                        <HorizontalAxisGridLines
+                            horizontalAxis={yAxis}
+                            bounds={innerBounds}
+                            strokeWidth={axisLineWidth}
+                        />
+                    </>
                 )}
-                <HorizontalAxisGridLines
-                    horizontalAxis={yAxis}
-                    bounds={innerBounds}
-                    strokeWidth={axisLineWidth}
-                />
                 {sizedSeries.map((series) => {
                     // Todo: add a "placedSeries" getter to get the transformed series, then just loop over the placedSeries and render a bar for each
                     const isNegative = series.value < 0

diff --git a/packages/@ourworldindata/grapher/src/stackedCharts/StackedDiscreteBarChart.tsx b/packages/@ourworldindata/grapher/src/stackedCharts/StackedDiscreteBarChart.tsx
@@ -682,19 +682,21 @@ export class StackedDiscreteBarChart
                     fill="rgba(255,255,255,0)"
                 />
                 {this.showHorizontalAxis && (
-                    <HorizontalAxisComponent
-                        bounds={bounds}
-                        axis={yAxis}
-                        preferredAxisPosition={innerBounds.bottom}
-                        labelColor={manager.secondaryColorInStaticCharts}
-                        tickMarkWidth={axisLineWidth}
-                    />
+                    <>
+                        <HorizontalAxisComponent
+                            bounds={bounds}
+                            axis={yAxis}
+                            preferredAxisPosition={innerBounds.bottom}
+                            labelColor={manager.secondaryColorInStaticCharts}
+                            tickMarkWidth={axisLineWidth}
+                        />
+                        <HorizontalAxisGridLines
+                            horizontalAxis={yAxis}
+                            bounds={innerBounds}
+                            strokeWidth={axisLineWidth}
+                        />
+                    </>
                 )}
-                <HorizontalAxisGridLines
-                    horizontalAxis={yAxis}
-                    bounds={innerBounds}
-                    strokeWidth={axisLineWidth}
-                />
                 {this.showLegend && (
                     <HorizontalCategoricalColorLegend manager={this} />
                 )}