fix(explorer): don't show stale data when switching to a view without…

… variables
owid · Jul 3, 2024 · 507131d · 507131d
1 parent 06849a9
commit 507131d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/explorer/Explorer.tsx b/explorer/Explorer.tsx
@@ -709,9 +709,15 @@ export class Explorer
         grapher.reset()
         this.updateGrapherFromExplorerCommon()
         grapher.updateFromObject(config)
-        await grapher.downloadLegacyDataFromOwidVariableIds(
-            inputTableTransformer
-        )
+        if (dimensions.length === 0) {
+            // If dimensions are empty, explicitly set the table to an empty table
+            // so we don't end up confusingly showing stale data from a previous chart
+            grapher.receiveOwidData(new Map())
+        } else {
+            await grapher.downloadLegacyDataFromOwidVariableIds(
+                inputTableTransformer
+            )
+        }
     }
 
     @action.bound private updateGrapherFromExplorerUsingColumnSlugs() {

diff --git a/packages/@ourworldindata/core-table/src/OwidTable.ts b/packages/@ourworldindata/core-table/src/OwidTable.ts
@@ -1051,10 +1051,7 @@ export class OwidTable extends CoreTable<OwidRow, OwidColumnDef> {
     }
 
     get isBlank(): boolean {
-        return (
-            this.tableDescription.startsWith(BLANK_TABLE_MESSAGE) &&
-            !this.numRows
-        )
+        return !this.numRows
     }
 }