Merge pull request #3944 from owid/fix-duplicate-indicators-explorers

🐛 fix duplicate indicators in indicator-based explorers
owid · Sep 12, 2024 · a83487c · a83487c
2 parents bf0b8db + 0a1544a
commit a83487c
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/explorer/Explorer.tsx b/explorer/Explorer.tsx
@@ -589,13 +589,22 @@ export class Explorer
         // set given variable IDs as dimensions to make Grapher
         // download the data and metadata for these variables
         const dimensions = config.dimensions ?? []
-
-        yVariableIdsList.forEach((yVariableId) => {
-            dimensions.push({
+        const variablesToLoad = yVariableIdsList
+            // Filter out variableIds that are already present in the dimensions array
+            .filter(
+                (yVariableId) =>
+                    !dimensions.some(
+                        (d) =>
+                            d.property === DimensionProperty.y &&
+                            d.variableId === yVariableId
+                    )
+            )
+            .map((yVariableId) => ({
                 variableId: yVariableId,
                 property: DimensionProperty.y,
-            })
-        })
+            }))
+        dimensions.push(...variablesToLoad)
+
         if (xVariableId) {
             const maybeXVariableId = parseIntOrUndefined(xVariableId)
             if (maybeXVariableId !== undefined)