Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(search): add global / shortcut to focus search bar #3916

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Aug 30, 2024

Anywhere the <Autocomplete> component is mounted, you can press / to focus it.

/ is also used by GitHub and YouTube. Unlike YouTube, Mousetrap ensures this also works on a German keyboard.

Mousetrap takes care that this doesn't happen when some textfield is currently focused.

This will save me seconds!

@owidbot
Copy link
Contributor

owidbot commented Aug 30, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-search-keyboard-shortcut

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-30 17:40:26 UTC
Execution time: 1.14 seconds

@marcelgerber marcelgerber changed the title enhance(search): add global / shortcut to focus search enhance(search): add global / shortcut to focus search bar Sep 2, 2024
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Sep 19, 2024
@marcelgerber marcelgerber merged commit 3a9fa35 into master Sep 19, 2024
15 of 17 checks passed
@marcelgerber marcelgerber deleted the search-keyboard-shortcut branch September 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants