Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix duplicate indicators in indicator-based explorers #3944

Merged
merged 2 commits into from
Sep 12, 2024
+14 −5
Merged

🐛 fix duplicate indicators in indicator-based explorers #3944

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b260f
🐛 fix duplicate indicators in indicator-based explorers
ikesau Sep 9, 2024
0a1544a
✨ only filter out duplicated y dimensions from explorers before loading
ikesau Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions explorer/Explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,13 +589,22 @@ export class Explorer
// set given variable IDs as dimensions to make Grapher
// download the data and metadata for these variables
const dimensions = config.dimensions ?? []

yVariableIdsList.forEach((yVariableId) => {
dimensions.push({
const variablesToLoad = yVariableIdsList
// Filter out variableIds that are already present in the dimensions array
.filter(
(yVariableId) =>
!dimensions.some(
(d) =>
d.property === DimensionProperty.y &&
d.variableId === yVariableId
)
)
.map((yVariableId) => ({
variableId: yVariableId,
property: DimensionProperty.y,
})
})
}))
dimensions.push(...variablesToLoad)

if (xVariableId) {
const maybeXVariableId = parseIntOrUndefined(xVariableId)
if (maybeXVariableId !== undefined)
Expand Down