🐛 (explorer) remove duplicate columns / TAS-613 #3957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on |
sophiamersmann
changed the title
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1 (9882f0) ❌ Edited: 2024-09-13 13:06:23 UTC |
ikesau
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3943
In #3793, we added a
dimensionsfield to all existing ETL-authored indicator configs, but explorers don't expect partial grapher configs to come with dimensions.Explorers specify their own dimensions, which led to the indicator of the partial grapher config being added twice. What made this worse is that the
dimensionsarray of the partial grapher config got mutated every time a different view was selected, which led to dimensions being added multiple times to the same Grapher.