Add gdoc tombstones #3979
Add gdoc tombstones #3979
Conversation
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 428 (89b864) ❌ Edited: 2024-10-03 16:16:57 UTC |
rakyi
force-pushed
the
add-gdoc-tombstones
branch
3 times, most recently
from
ce053c1
to
c6cdca9
Compare
There was a problem hiding this comment.
Nice! I like it 👍
I wonder if we should have some admin UI to manage tombstones with, though. Obviously I couldn't resist trying to redelete a slug that already had a tombstone (which fails) plus I can imagine people potentially wanting to read/update/delete the tombstones. Just a simple table would work well, I think?
rakyi
force-pushed
the
add-gdoc-tombstones
branch
2 times, most recently
from
a825865
to
914fc8a
Compare
rakyi
force-pushed
the
add-gdoc-tombstones
branch
from
914fc8a
to
7302276
Compare
rakyi
force-pushed
the
add-gdoc-tombstones
branch
from
5649836
to
a6287f0
Compare
| `SELECT * | ||
| FROM images | ||
| WHERE id IN (SELECT DISTINCT imageId FROM posts_gdocs_x_images) | ||
| OR filename IN (SELECT DISTINCT relatedLinkThumbnail FROM posts_gdocs_tombstones)` |
There was a problem hiding this comment.
Does this make sense, @ikesau?
There was a problem hiding this comment.
BTW, is subquery faster than a join, or why are we doing that?
There was a problem hiding this comment.
Will finish the review tomorrow but one thing that jumps out here is that we could get duplicates in images now, I think? Maybe SELECT DISTINCT * could help.
I don't know of a particular reason to subqueries over joins in this case. Feel free to change it to whichever's more legible.
There was a problem hiding this comment.
I added DISTINCT and index on relatedLinkThumbnail.
|
@ikesau could you review the new comments since your last review, pls? |
rakyi
force-pushed
the
add-gdoc-tombstones
branch
2 times, most recently
from
cecbc74
to
a400bb1
Compare
- Copy fixes - Allow external related links - Include Wayback Machine link based on a checkbox
rakyi
force-pushed
the
add-gdoc-tombstones
branch
from
a400bb1
to
9f12eb6
Compare
Closes #3902
Without reason or related link specified:
With reason and related link specified:
Generic 404:
Modified existing delete modal in the admin (remaining fields are visible only when the checkbox is checked):