✨ reordered owid distinct colors

[danyx23]

This fixes #3898

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-owid-distinct-colors-reordered

• Site-screenshots: https://github.com/owid/site-screenshots/compare/owid-distinct-colors-reordered
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/owid-distinct-colors-reordered

SVG tester:

Number of differences (default views): 736 (7a96a0) ❌
Number of differences (all views): 370 (8db9d0) ❌

Edited: 2024-10-03 18:02:50 UTC
Execution time: 1.20 seconds

[lucasrodes]

hey @danyx23,
Thanks for the rapid implementation! I think this fixes a substantial part of #3898, but the initial confusion about how colors are chosen is still not resolved.

I think I understood how colors are picked when the user selects/unselects entities in charts. I wonder if this is the way to go. Elaborated on this here: #3898 (comment)

[danyx23]

@lucasrodes yes, this only implements a better order of colors which makes the default color choices on many of our charts substantially better.

I see your other point about how selecting and deselecting is a bit weird but there are several other concerns that play into that part of the codebase (e.g. persistence of colors on entities coming in via facetting or explorers). It's possible that we can improve that in the future but this is not a quick fix.