fixes #191 and #192: Guard against stack overflow #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guusdk
force-pushed
the
191_stack-overflow-fix
branch
from
e3a22fa
to
05705a7
Compare
guusdk
changed the title
This adds a quick and dirty guard against a stack overflow condition when serializing and deserializing severely nested data.
guusdk
force-pushed
the
191_stack-overflow-fix
branch
from
05705a7
to
629a587
Compare
guusdk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quick and dirty guard against a stack overflow condition when deserializing severely nested data.
Please note that this is a very crude solution, that has seen little testing. I'm not sure if this adequately guards against all forms of stack overflow.