This repository has been archived by the owner on Oct 31, 2018. It is now read-only.
Minor efficiency improvement for editing and deleting #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calendar data unless it's actually going to be used for something. Makes for a performance improvement when the user doing the deleting or editing is the calendar's owner anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a problem I was having (caused by some bad calendar data, I think), I happened to notice that the code for deleting and editing was reading/parsing the existing calendar data in circumstances where it isn't actually being used. Moving the call into the
ifblock means this is only done when the$oldvobjectwill be needed.