Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: check keyring status beforehand and exit if not ready and unlocked within the timeout #71

Merged
merged 2 commits into from
Jan 13, 2025
Merged

build: check keyring status beforehand and exit if not ready and unlocked within the timeout #71

merged 2 commits into from
Jan 13, 2025

Conversation

saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Jan 7, 2025 •
edited
Loading

@saw-jan saw-jan self-assigned this Jan 7, 2025
@saw-jan saw-jan force-pushed the build/exit-if-keyring-not-ready branch from 8f767f7 to f0c6da1 Compare January 10, 2025 11:10
@saw-jan saw-jan marked this pull request as ready for review January 10, 2025 11:11
@saw-jan
Copy link
Collaborator Author

saw-jan commented Jan 10, 2025

^ @ishabaral

@saw-jan saw-jan force-pushed the build/exit-if-keyring-not-ready branch from f0c6da1 to a19e879 Compare January 13, 2025 05:54
phil-davis
phil-davis approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.
We will only know that pipelines start more reliably by running this for a while.

@saw-jan
Copy link
Collaborator Author

saw-jan commented Jan 13, 2025

Yeah, this only adds keyring checks and the proper fix might be in the test code.
I am checking the image build in owncloud/client#12028

@phil-davis phil-davis merged commit 6229eb8 into master Jan 13, 2025
1 check passed
@phil-davis phil-davis deleted the build/exit-if-keyring-not-ready branch January 13, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@saw-jan saw-jan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @phil-davis