Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with invalid authentication #632

Closed
phil-davis opened this issue Dec 12, 2019 · 2 comments
Closed

Test with invalid authentication #632

phil-davis opened this issue Dec 12, 2019 · 2 comments
Assignees

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Dec 12, 2019

We should know that all the core endpoints implement proper authentication.

Review existing tests (e.g. in apiAuth and apiAuthOcs suites). Enhance the test scenarios so that:

  • all endpoints are covered (webDAV, OCS, sharing-comments-tags...) with all actions (GET/PUT/POST/PROPFIND...)
  • test with sending no authentication
  • test with sending valid UID but no password
  • test with sending valid UID but wrong password
  • test with sending an invalid UID but the correct password of the user concerned
  • test with sending the authentication (UID plus correct password) of another user (to make sure one user cannot access another user's data without proper sharing-permissions)

This came from the big issue #297

@dpakach
Copy link
Contributor

dpakach commented Dec 23, 2019

@phil-davis I think we have good enough coverage on these tests. Do you think we can close this now?

@phil-davis
Copy link
Contributor Author

I agree - closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants