Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for invalid authentication on webDav endpoints with LOCK and PROPPATCH #36606

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Dec 18, 2019

Description

Add API acceptance tests for checking the webDav endpoints with invalid authentication methods using HTTP request methods LOCK and PROPPATCH

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #36606 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36606   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19059    19059           
=========================================
  Files          1268     1268           
  Lines         74508    74508           
  Branches       1311     1311           
=========================================
  Hits          48188    48188           
  Misses        25934    25934           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54.02% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19059 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d4358...2a356bf. Read the comment docs.

Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

@dpakach dpakach requested a review from phil-davis December 18, 2019 08:56
@haribhandari07
Copy link
Contributor

LGTM

@phil-davis phil-davis merged commit c2d03b3 into master Dec 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the webdav-auth-lock-proppatch branch December 18, 2019 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants