Cannot build

[PVince81]

Steps

1. git checkout release-2.4.2
2. make dist

Expected

Successful build

Actual

Error:

± % make dist
rm -Rf /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist
rm -Rf /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity; mkdir -p /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity
cp -R appinfo css img js l10n lib templates README.md CHANGELOG.md CONTRIBUTING.md /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity
/home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/../../occ integrity:sign-app --privateKey="/home/vincent/.owncloud/certificates/activity.key" --certificate="/home/vincent/.owncloud/certificates/activity.crt" --path="/home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity"
ownCloud is not installed - only a limited number of commands are available
Successfully signed "/home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity"
tar -czf /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity.tar.gz -C /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist activity
tar -cjf /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist/activity.tar.bz2 -C /home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity/build/dist activity
make appstore
make[1]: Entering directory '/home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity'
rm -rf 
mkdir -p 
mkdir: missing operand
Try 'mkdir --help' for more information.
make[1]: *** [Makefile:121: appstore] Error 1
make[1]: Leaving directory '/home/vincent/Private/Work/workspace/owncloud-for-signing/apps/activity'
make: *** [Makefile:115: dist] Error 2

@phil-davis @paurakhsharma please have a look

[PVince81]

note: this is blocking the release of the activity app. the release itself isn't urgent but would be good to solve this problem this week

[phil-davis]

The problem was introduced in #660 and I have no idea why the PR was approved the way it was, or if the code was accidentally added in a rebase after approval or... - see comment https://github.com/owncloud/activity/pull/660/files#r255856913

See #708 for the "minimal" fix.

[phil-davis]

@PVince81 this should be fixed. Close when you have ttried and got success.

[PVince81]

solved, thanks