Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate make dist target #708

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Remove duplicate make dist target #708

merged 1 commit into from
Feb 12, 2019

Conversation

phil-davis
Copy link
Contributor

Issue #700

Somehow this code was added in #660 - see comment https://github.com/owncloud/activity/pull/660/files#r255856913
It duplicated the existing make dist target.

@phil-davis
Copy link
Contributor Author

@paurakhsharma do you have any memory about this?
@DeepDiver1975 I see that you were involved in some review of #660 and that various other code blocks were added to Makefile - do you have any memory about it?

@phil-davis phil-davis mentioned this pull request Feb 12, 2019
@phil-davis phil-davis force-pushed the remove-appstore-build branch from f15817b to 24bc074 Compare February 12, 2019 11:18
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #708   +/-   ##
========================================
  Coverage      83.9%   83.9%           
  Complexity      502     502           
========================================
  Files            45      45           
  Lines          1802    1802           
========================================
  Hits           1512    1512           
  Misses          290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ba1665...24bc074. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #708   +/-   ##
========================================
  Coverage      83.9%   83.9%           
  Complexity      502     502           
========================================
  Files            45      45           
  Lines          1802    1802           
========================================
  Hits           1512    1512           
  Misses          290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d6ceb...d457abb. Read the comment docs.

@phil-davis phil-davis force-pushed the remove-appstore-build branch from 24bc074 to d457abb Compare February 12, 2019 15:34
@PVince81 PVince81 merged commit afd998f into master Feb 12, 2019
@PVince81 PVince81 deleted the remove-appstore-build branch February 12, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants