-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] [tests-only] Added scenarios to check activity list after share is expired for federated share #1115
[full-ci] [tests-only] Added scenarios to check activity list after share is expired for federated share #1115
Conversation
| object_type | /^files$/ | | ||
| subject_prepared | /^You created <collection><file link=\"%base_url%\/(index\.php\/)?apps\/files\/\?dir=\/&scrollto=lorem\.txt\" id=\"\d+\">lorem\.txt<\/file><file link=\"%base_url%\/(index\.php\/)?apps\/files\/\?dir=\/" id=\"\d+\">\/<\/file><\/collection>$/ | | ||
And using server "REMOTE" | ||
And the activity number 1 of user "Brian" should match these properties: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we leave a comment here that user brian should have 3 activities but has only 2 are found and no expiry activity is there for user brian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment has been added in the scenario.
user Alice (sharer) should have 3 activities but has only 2 and no expiry activity is there for user Alice.
For Brian (sharee) the inappropriate message like share is unshared
instead of share has expired
is in the activity list.
Issues reported here: #1117, #1116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be nice if this message was more specific. The LOCAL
server deleted the share when it realized that it was expired. Someone who looks at fixing the issue #1117 can discuss what activity message Brian and see if it is possible to improve this.
e0b3539
to
f3dbe13
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
This PR adds a scenario to check the activity list after the share is expired for the federated share.
Part of issue #968