Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Added scenarios to check activity list after share is expired for federated share #1115

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jun 20, 2022

This PR adds a scenario to check the activity list after the share is expired for the federated share.

Part of issue #968

@grgprarup grgprarup self-assigned this Jun 20, 2022
@grgprarup grgprarup marked this pull request as ready for review June 22, 2022 03:36
| object_type | /^files$/ |
| subject_prepared | /^You created <collection><file link=\"%base_url%\/(index\.php\/)?apps\/files\/\?dir=\/&scrollto=lorem\.txt\" id=\"\d+\">lorem\.txt<\/file><file link=\"%base_url%\/(index\.php\/)?apps\/files\/\?dir=\/" id=\"\d+\">\/<\/file><\/collection>$/ |
And using server "REMOTE"
And the activity number 1 of user "Brian" should match these properties:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we leave a comment here that user brian should have 3 activities but has only 2 are found and no expiry activity is there for user brian.

Copy link
Contributor Author

@grgprarup grgprarup Jun 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment has been added in the scenario.
user Alice (sharer) should have 3 activities but has only 2 and no expiry activity is there for user Alice.
For Brian (sharee) the inappropriate message like share is unshared instead of share has expired is in the activity list.
Issues reported here: #1117, #1116

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it would be nice if this message was more specific. The LOCAL server deleted the share when it realized that it was expired. Someone who looks at fixing the issue #1117 can discuss what activity message Brian and see if it is possible to improve this.

@grgprarup grgprarup force-pushed the add-scenarios-to-check-activity-list-after-fed-share-expire branch from e0b3539 to f3dbe13 Compare June 27, 2022 08:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit 22383c3 into master Jul 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-scenarios-to-check-activity-list-after-fed-share-expire branch July 1, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants