-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI setup for running tests in drone #104
Conversation
70f00be
to
b1a8ceb
Compare
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
Coverage 99.63% 99.63%
Complexity 63 63
=========================================
Files 8 8
Lines 272 272
=========================================
Hits 271 271
Misses 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goalposts change a bit every week. See my comments. I think the PRs that I referred to in password_policy
and files_antivirus
are now good example :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the parallel-lint is not used anywhere anyway, so it can easily be removed.
The rest of it looks good.
In the next PRs we can:
- actually delete travis.yml and get "Travis required" taken off the repo.
- add owncloud-coding-standard to the matrix and make the actual needed code changes
- sort out moving unit tests into the
tests/unit
folder
Implement style check for owncloud coding standard Add make targets for running tests Add `.drone.yml` file for drone configurations
drone CI setup
fixes #101
.drone.yml
file for drone configurations