Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI setup for running tests in drone #104

Merged
merged 1 commit into from
Nov 26, 2018
Merged

CI setup for running tests in drone #104

merged 1 commit into from
Nov 26, 2018

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 23, 2018

drone CI setup

fixes #101

  • Implement style check for owncloud coding standard
  • Add make targets for running tests
  • Add .drone.yml file for drone configurations

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage     99.63%   99.63%           
  Complexity       63       63           
=========================================
  Files             8        8           
  Lines           272      272           
=========================================
  Hits            271      271           
  Misses            1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbb071...426d315. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goalposts change a bit every week. See my comments. I think the PRs that I referred to in password_policy and files_antivirus are now good example :)

.gitignore Show resolved Hide resolved
.php_cs.dist Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
phpunit.xml Show resolved Hide resolved
@dpakach dpakach mentioned this pull request Nov 26, 2018
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parallel-lint is not used anywhere anyway, so it can easily be removed.
The rest of it looks good.
In the next PRs we can:

  • actually delete travis.yml and get "Travis required" taken off the repo.
  • add owncloud-coding-standard to the matrix and make the actual needed code changes
  • sort out moving unit tests into the tests/unit folder

Implement style check for owncloud coding standard
Add make targets for running tests
Add `.drone.yml` file for drone configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drone setup
2 participants