Add new koko test (070) and eslint housekeeping #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add new 070-user-group-search-and-share test and docs from the koko test paper - add new groups api and add those to the tdk client - add several es-lint rules to the default config and apply those
| @@ -16,56 +15,66 @@ export class Search { | |||
| this.#api = api; | |||
| } | |||
|
|
|||
| sharee(search: string, itemType: ItemType): RefinedResponse<'text'> { | |||
There was a problem hiding this comment.
just a suggestion: maybe it make sence to create separate sharee.ts file for method sharee and rename sharee as get.
then we get userClient.sharee.get(adminCredential.login, ItemType.folder)
Just `search' I mean using REPORT request
Otherwise ok. I ran the tests - everything works fine
There was a problem hiding this comment.
thanks @ScharfViktor, sorry for that but maybe it makes more sense to just merge those 4PRs and concentrate on, #52. As described here this finishes the api's:
| const createdShareResponse = userClient.share.create( | ||
| folderMovedName, | ||
| adminCredential.login, | ||
| const shareeSearchResponse = userClient.search.sharee(adminCredential.login, ItemType.folder) |
There was a problem hiding this comment.
then we can userClient.sharee.get(adminCredential.login, ItemType.folder)
There was a problem hiding this comment.
see above, sorry 😢
butonic
approved these changes
Apr 18, 2023
fschade
added a commit
that referenced
this pull request
Apr 18, 2023
#47) (#48) * feat(test): add new koko tests and eslint housekeeping - add new 070-user-group-search-and-share test and docs from the koko test paper - add new groups api and add those to the tdk client - add several es-lint rules to the default config and apply those * fix(artifacts): rebuild artifacts after rebase * fix(test): fix wrong path * feat(test): add new koko tests and some test housekeeping - add new 080-create-space test and docs based on the koko test paper - add client version guard to protect the test from unsupported client versions - rename the api tdk package to endpoints, to not have a api.api route which is needed for ocis - add eslint rule to have linebreaks between class members - stop using k6 response json method - add client endpoints for application - add client endpoints for drive - add client endpoints for role * - add missing client demos to the kitchen sink test - fix static space creation count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code abstract
Description
sorry for all that noise, essentially this pr only touches test files, specially the newly added
070-user-group-search-and-sharetest and docs. Unfortunately i had to apply some new eslint rules for better code style which results in many chore changes.to review you should primary review:
everything else is noise from the linter (you can review it if you want to 😄)
Test abstract
The
user group search and sharetest creates a configurable amount of share receivers (users and groups),folders and files, once the provisioning is done, the users search for all share receivers (users and groups),
and then shares the provisioned resources with each.
To confirm that everything went well, the test compares the resolved share recipient with initial share receiver.
admincreatesNusers.Ncan be set by using the k6--vusoption.admincreatesNshare receiver groups.Ncan be set with the environment variableSHARE_RECEIVERS_GROUP_COUNT.admincreatesNshare receiver users.Ncan be set with the environment variableSHARE_RECEIVERS_USER_COUNT.userlogs into the system individually.usercreatesNfolders.Ncan be set with the environment variableASSETS_FOLDER_COUNT.usersearches for each share receiver.usershares each folder to all share receivers.usercreatesNtxt files.Ncan be set with the environment variableASSETS_TEXT_DOCUMENT_COUNT.usersearches for each share receiver.usershares each txt file to all share receivers.userdeletes the created files and folders to finalize the test.admindeletes the created users.admindeletes the created share receiver users.admindeletes the created share receiver groups.