Update offline icon #11910
Merged
Update offline icon #11910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #11905
|
@tbsbdr the icon appears to be "576x512".... which might cause issues.... |
|
what should it be? 1:1? |
Yes. 512x512 |
|
so do we always need to customize icons taken from font awesome? they all seem to vary their aspect ratio :( |
|
hmm, I think this might no longer be an issue and had been a legacy condition from the time we used different sized pngs.... |
|
I checked (on macOS) and the icon is proportionally scaled (meaning: it doesn't look squashed/stretched in one direction) |
erikjv
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11905
Old:
New: