Draft: Fix tab order in basic auth login screen #11924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe we should always show the logout button, and use the visibility to show/hide it? Or have a dummy item at the bottom which forwards the focus to the widget when it gets tab focus? |
This was referenced Oct 10, 2024
TheOneRing
suggested changes
Oct 14, 2024
| // with logout button | ||
| logOutButton.item.logOutButton.forceActiveFocus(Qt.TabFocusReason); | ||
| } else { | ||
| // there is no lougout button | ||
| widget.parentFocusWidget.focusNext(); |
There was a problem hiding this comment.
shouldn't parentFocusWidget be able to take care?
| } | ||
| event.accepted = true; |
There was a problem hiding this comment.
erikjv
force-pushed
the
work/fix-basic-auth-tab-order
branch
from
7273c87
to
145097c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11912