Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement for some vcard tel type #624

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Terge3141
Copy link

The following 'tel' types are not shown correctly for a contact:
TYPE=VOICE;TYPE=CELL and TYPE=VOICE;TYPE=HOME
Both are shown as 'VOICE', on Android as Mobile and Home, respectively

Suggestion to change types:
TYPE=VOICE;TYPE=CELL --> CELL
TYPE=VOICE;TYPE=HOME --> HOME,VOICE

Example (sent by Android CardDAV-Sync free 0.4.201):
BEGIN:VCARD
VERSION:3.0
TEL;TYPE=VOICE;TYPE=HOME:41111
BDAY:2017-11-10
FN:CopyTest
TEL;TYPE=VOICE;TYPE=CELL:31111
UID:52e91035-f94a-4e5d-81cc-4d75bf07a0c7
N:;CopyTest;;;
PRODID:-//dmfs.org//mimedir.vcard//EN
REV:20171112T211147Z
END:VCARD

@codecov
Copy link

codecov bot commented Jan 27, 2018

Codecov Report

Merging #624 into master will decrease coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   18.72%   18.49%   -0.24%     
==========================================
  Files          51       51              
  Lines        1036     1049      +13     
==========================================
  Hits          194      194              
- Misses        842      855      +13
Impacted Files Coverage Δ
js/filters/vCard2JSON_filter.js 6.25% <0%> (-27.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6cb9c...41dc3d7. Read the comment docs.

@Julian1998 Julian1998 removed their assignment Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants