Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename make test-php to test-php-unit #34638

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Rename make test-php to test-php-unit #34638

merged 1 commit into from
Feb 28, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 28, 2019

Description

Rename the make target test-php to test-php-unit to be consistent with apps.

drone uses its own script drone/test-phpunit.sh so there is nothing to modify in drone. As part of the issue below, that will be sorted out to see if drone and make test-php-unit should converge to some common execution path.

Related Issue

owncloud/QA#604

Motivation and Context

Be consistent.

How Has This Been Tested?

Local unit test run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34638   +/-   ##
=========================================
  Coverage     65.23%   65.23%           
  Complexity    18438    18438           
=========================================
  Files          1203     1203           
  Lines         69825    69825           
  Branches       1280     1280           
=========================================
  Hits          45549    45549           
  Misses        23904    23904           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.63% <ø> (ø) 18438 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6332f...2edf2eb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34638   +/-   ##
=========================================
  Coverage     65.23%   65.23%           
  Complexity    18438    18438           
=========================================
  Files          1203     1203           
  Lines         69825    69825           
  Branches       1280     1280           
=========================================
  Hits          45549    45549           
  Misses        23904    23904           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.63% <ø> (ø) 18438 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6332f...2edf2eb. Read the comment docs.

@phil-davis
Copy link
Contributor Author

phil-davis commented Feb 28, 2019

@PVince81 doing this "easy" change will make running unit tests as a developer more "standard". It just needs an easy doc change and notifying developers so they do not get surprised by the change in core.

I made the backport so that both are ready to merge at the same time for a "seamless" developer experience.

@phil-davis
Copy link
Contributor Author

Backport stable10 #34640

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

@phil-davis please also grep the documentation in case it needs replacing there as well

@PVince81 PVince81 merged commit d9e9dbd into master Feb 28, 2019
@PVince81 PVince81 deleted the test-php-unit branch February 28, 2019 11:21
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants