-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename make test-php to test-php-unit #34638
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34638 +/- ##
=========================================
Coverage 65.23% 65.23%
Complexity 18438 18438
=========================================
Files 1203 1203
Lines 69825 69825
Branches 1280 1280
=========================================
Hits 45549 45549
Misses 23904 23904
Partials 372 372
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #34638 +/- ##
=========================================
Coverage 65.23% 65.23%
Complexity 18438 18438
=========================================
Files 1203 1203
Lines 69825 69825
Branches 1280 1280
=========================================
Hits 45549 45549
Misses 23904 23904
Partials 372 372
Continue to review full report at Codecov.
|
@PVince81 doing this "easy" change will make running unit tests as a developer more "standard". It just needs an easy doc change and notifying developers so they do not get surprised by the change in core. I made the backport so that both are ready to merge at the same time for a "seamless" developer experience. |
Backport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@phil-davis please also grep the documentation in case it needs replacing there as well |
Description
Rename the
make
targettest-php
totest-php-unit
to be consistent with apps.drone uses its own script
drone/test-phpunit.sh
so there is nothing to modify in drone. As part of the issue below, that will be sorted out to see if drone andmake test-php-unit
should converge to some common execution path.Related Issue
owncloud/QA#604
Motivation and Context
Be consistent.
How Has This Been Tested?
Local unit test run.
Types of changes
Checklist:
Open tasks: