Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] [stable10] Provide common make files #34661

Closed
wants to merge 6 commits into from

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 4, 2019

Backport #34660

This backport is here so that there is a stable10 branch that I can use for PoC testing from apps. I am keeping it in sync with whatever happens to the master PR.

Please make review comments in the master PR.

Note: See discussion in master PR. This PR is being left here for now, until we get back to designing a better solution.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #34661 into stable10 will decrease coverage by 2.6%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34661      +/-   ##
==============================================
- Coverage       66.61%      64%   -2.61%     
+ Complexity      19409    19246     -163     
==============================================
  Files            1162     1276     +114     
  Lines           64738    75793   +11055     
  Branches            0     1291    +1291     
==============================================
+ Hits            43127    48515    +5388     
- Misses          21611    26899    +5288     
- Partials            0      379     +379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (?) 0 <ø> (?)
#phpunit 65.16% <ø> (-1.46%) 19246 <ø> (-163)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.84% <0%> (-9.39%) 62% <0%> (ø)
lib/private/Files/Storage/DAV.php 81.09% <0%> (-7.78%) 0% <0%> (-161%)
lib/private/DB/AdapterOCI8.php 86.66% <0%> (-6.2%) 4% <0%> (ø)
lib/private/DB/OracleConnection.php 66.66% <0%> (-1.91%) 12% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (-1.61%) 18% <0%> (ø)
apps/files_external/lib/Command/Backends.php 0% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_external/lib/Lib/Backend/DAV.php 0% <0%> (ø) 0% <0%> (?)
core/js/sharedialogexpirationview.js 76.56% <0%> (ø) 0% <0%> (?)
... and 156 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87240fd...a07ac67. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #34661 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34661   +/-   ##
===========================================
  Coverage       64.21%   64.21%           
  Complexity      19908    19908           
===========================================
  Files            1277     1277           
  Lines           76366    76366           
  Branches         1292     1292           
===========================================
  Hits            49036    49036           
  Misses          26951    26951           
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.37% <ø> (ø) 19908 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d445ab4...6443c8c. Read the comment docs.

@phil-davis phil-davis force-pushed the stable10-provide-common-makefiles branch 4 times, most recently from 71058bc to e0589b7 Compare March 8, 2019 15:56
@phil-davis phil-davis changed the title [WIP] [stable10] Provide common make files [PoC] [stable10] Provide common make files Mar 24, 2019
@phil-davis phil-davis force-pushed the stable10-provide-common-makefiles branch from e0589b7 to ece4ec6 Compare March 24, 2019 06:15
@phil-davis phil-davis force-pushed the stable10-provide-common-makefiles branch from ece4ec6 to 6443c8c Compare April 3, 2019 05:18
@phil-davis
Copy link
Contributor Author

Closing see comment owncloud/richdocuments#253 (comment)

@phil-davis phil-davis closed this Jul 20, 2019
@phil-davis phil-davis deleted the stable10-provide-common-makefiles branch June 18, 2020 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant