Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] skipOnEncryption filesExternalWebdavOwncloud issue-encryption-181 #36993

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

phil-davis
Copy link
Contributor

Description

This recently-added scenario also fails with the combination of encryption and webDAV-owncloud local storage. So skip it.

Related Issue

owncloud/encryption#181

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #36993 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36993      +/-   ##
============================================
- Coverage     64.46%   64.15%   -0.32%     
  Complexity    19138    19138              
============================================
  Files          1270     1270              
  Lines         74877    74877              
  Branches       1329     1329              
============================================
- Hits          48271    48035     -236     
- Misses        26215    26451     +236     
  Partials        391      391              
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.26% <ø> (-0.36%) 19138.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/PostgreSqlMigrator.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php 0.00% <0.00%> (-88.89%) 3.00% <0.00%> (ø%)
lib/private/DB/AdapterOCI8.php 0.00% <0.00%> (-86.67%) 4.00% <0.00%> (ø%)
lib/private/DB/AdapterPgSql.php 0.00% <0.00%> (-85.72%) 2.00% <0.00%> (ø%)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0.00% <0.00%> (-85.19%) 18.00% <0.00%> (ø%)
lib/private/DB/OracleMigrator.php 0.00% <0.00%> (-76.85%) 10.00% <0.00%> (ø%)
lib/private/DB/OracleConnection.php 0.00% <0.00%> (-66.67%) 12.00% <0.00%> (ø%)
lib/private/DB/ConnectionFactory.php 75.34% <0.00%> (-15.07%) 22.00% <0.00%> (ø%)
lib/private/DB/Adapter.php 82.71% <0.00%> (-6.18%) 25.00% <0.00%> (ø%)
lib/private/DB/MDB2SchemaManager.php 85.96% <0.00%> (-5.27%) 17.00% <0.00%> (ø%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cff79f5...8043047. Read the comment docs.

@phil-davis phil-davis merged commit b07c9df into master Feb 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the skipOnEncryption-filesExternalWebdavOwncloud branch February 20, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants