Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make file targets for code check #185

Closed
phil-davis opened this issue Nov 21, 2018 · 2 comments
Closed

Make file targets for code check #185

phil-davis opened this issue Nov 21, 2018 · 2 comments
Assignees

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Nov 21, 2018

https://github.com/owncloud/customgroups/blob/master/rules/tests.mk has make targets called:

make test-codecheck
make test-codecheck-deprecations

Other repos seem to have:

make test-php-codecheck

It also has various stuff like:

make test-syntax-php
make test-syntax-js
make test-codecheck-deprecations
...

And it has the whole structure of a rules folder containing various *.mk files.

What is good about the way the build and CI is organized? (and should be replicated consistently to other repos)

What should be refactored in this repo to make it like other app repos?

@PVince81 @DeepDiver1975 @pmaier1

Part of owncloud/QA#582

@phil-davis
Copy link
Contributor Author

@patrickjahns I just realized that I picked the wrong Patrick when I pinged people for this issue.
Do you know anything about the history of the Makefile structure in this repo?
Or comments about what we should do to "standardize" this?

@phil-davis phil-davis self-assigned this Feb 28, 2019
@phil-davis
Copy link
Contributor Author

PR #205 sorts out "standardizing" this to be reasonably similar to the way things are organized in the other apps, and removes "excess" stuff from the make files.

That should be enough for now. And we will be refactoring "the makefile universe" again for owncloud/QA#604 when we agree on a design for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants