Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort out makefiles #205

Merged
merged 4 commits into from
Feb 28, 2019
Merged

Sort out makefiles #205

merged 4 commits into from
Feb 28, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 28, 2019 •
edited
Loading

Issue #185

  • remove test-acceptance (there is now test-acceptance-api)
  • add owncloud code style for each PHP version, to cover "lint"
  • remove test-syntax-php lint checks
  • remove test-php (there is now test-php-unit)
  • point PHPUNIT at the phpunit in core, and remove it from the local composer.json
  • remove test-upload-coverage (that happens differently in .drone.yml now)
  • remove the various help output and replace with the comment-style text that goes with each target

@phil-davis phil-davis self-assigned this Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited
Loading

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #205   +/-   ##
========================================
  Coverage      84.4%   84.4%           
  Complexity      301     301           
========================================
  Files            22      22           
  Lines           962     962           
========================================
  Hits            812     812           
  Misses          150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890926b...270cd63. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #205   +/-   ##
========================================
  Coverage      84.4%   84.4%           
  Complexity      301     301           
========================================
  Files            22      22           
  Lines           962     962           
========================================
  Hits            812     812           
  Misses          150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890926b...c388c39. Read the comment docs.

@phil-davis phil-davis mentioned this pull request Feb 28, 2019
Closed
@phil-davis phil-davis merged commit cdc4168 into master Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the sort-out-makefiles branch February 28, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

Assignees

@phil-davis phil-davis

Labels
4 - To release QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phil-davis @individual-it