Improve spinners in members view #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spinner for autocomplete now appears when loading autocomplete list or adding member. Spinner for list appears when loading list only. New spinner appears when toggling role. Tooltip now properly removed when toggling role
|
When removing yourself as admin of a group and changing your mind, the spinner spins forever.
|
|
@SergioBertolinSG fixed, please try again |
|
Works. A bit nitpicking: The profile pictures of the members of the groups blink when changing its role. |
I saw this, likely no quick fix because it's related to how the avatar code works: basically it needs to do a server call to find out whether the user has an avatar. Would require some kind of caching. This is something for another time. |
SergioBertolinSG
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinner for autocomplete now appears when loading autocomplete list or
adding member.
Spinner for list appears when loading list only.
New spinner appears when toggling role.
Tooltip now properly removed when toggling role
For #33 (comment)