-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update the building page #242
base: master
Are you sure you want to change the base?
Conversation
http://download.opensuse.org/repositories/isv:/ownCloud:/desktop/ is dead. The first fix for https://doc.owncloud.com/desktop/next/appendices/building.html#linux is Replace
with
Client sources since 2.6.3 are no longer available at SUSE OBS. we now always pull client sorces from github. I cannot say how long qt5152 actually lives. .. we'll probably have Qt version 5.15.3/4/5 soon... |
I suggest to remove http://download.opensuse.org/repositories/isv:/ownCloud:/desktop/ from OBS. |
The link for 'Visual Studio 2019'is currently documented as https://visualstudio.microsoft.com/en/downloads/
The installer of Visual studio community 2019 - 16.11.16 offers many options:
These two seem to be the best match to avoid a craft error message
The installer reports a total download size of 1.44 GB for this. ( If the Spectre-Libs shown there are also required, then the Download size is 2,35 GB ) |
Recommended way to build is https://github.com/owncloud/ownbuild/blob/master/README.md |
ownbuild.py works for all three windows, mac and linux. We should reduce the docu to refer to the ownbuild repo, and the README.txt there: https://github.com/owncloud/ownbuild#readme Only one special case: how to call ownbuild with linux using system libraries. The cmake options also should only e documented in developer documentaiton README style.
succeed to build the client from master branch cleanly, if the documented initialization But building from branch 2.10 Instructions are missing, how to build from a locally patched tree. |
Based on the discussion today with @jnweiger @TheOneRing @gabi18 the PR has changed the following way: With commit Having this, ALL building maintenance has to be done in the ownbuild repo - source/code and instruction (readme) wise. This is a good thing as all is now concentrated and maintained by those who are responsible for client building. @TheOneRing pls approve |
|
||
Follow the xref:generic-build-instructions[generic build instructions], starting with step 2. | ||
|
||
== Linux with System Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we agree to keep this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to move 'Linux with System Dependencies' also into github. e.g. as part of the ownbuild README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to Ownbuild
@mmattel I removed myself from the Reviewers list. The small amount of text remaining looks good. It is for others to decide and review this restructuring. Note: there are conflicts reported by Git at the moment - so this needs a rebase. |
---- | ||
LD_LIBRARY_PATH=/opt/ownCloud/qt-5.12.4/lib/x86_64-linux-gnu/:/Users/path/to/client/../install/lib/x86_64-linux-gnu/ /Users/path/to/client/../install/bin/owncloud | ||
---- | ||
ownCloud provides an own repository as starting point for building the client. All necessary details can be found there. See the {ownbuild-url}[ownbuild repository] to proceed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is good, we should avoid redundancies wherever possible. However, this implies that we have to improve the README there to be beginner (and generally user) friendly.
site.yml
Outdated
latest-branded-version: 'next' | ||
previous-branded-version: 'next' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is next
some kind of "magic keyword"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. There always must be a version named next
and if required more versions like 2.10 as for desktop. Note that branding does not have versioning, therefore only next is used. That keyword is used in the URL to specify the release you want to look at 😄
e098217
to
f01c449
Compare
d255c89
to
05606ee
Compare
This is the first part fixing #241 (Add cmake option for building the client to disable auto updater)
Before weare going to implement additional cmake options, we need to update the page as it needs a base review.
IMPORTANT
When looking into the given links adding the deb packages, you see that releases end with 2.6 (!!) and are 2 years old, see:
http://download.opensuse.org/repositories/isv:/ownCloud:/desktop/
Currently we are shipping 2.10 and are working on 2.11 ...
I need advise how to hande this before we are going to merge this PR because imho this is not a good sign showing customers heavy outdated release bases for building their client.
@dragotin @TheOneRing @michaelstingl @jnweiger @gabi18 @GeraldLeikam
@dpapac fyi