Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow enabling async metadata propagation #789

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

butonic
Copy link
Member

@butonic butonic commented Nov 5, 2024

This PR allows enabling the async pmetadata propagation. It defaults to off and a 5s delay.

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic marked this pull request as ready for review November 5, 2024 14:39
@butonic
Copy link
Member Author

butonic commented Nov 5, 2024

cc @kobergj

Comment on lines +80 to +81
- name: OCIS_DECOMPOSEDFS_PROPAGATOR
value: "async"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owncloud.dev says:

The propagator used for decomposedfs. At the moment, only ‘sync’ is fully supported, ‘async’ is available as an experimental option.

(from https://owncloud.dev/services/storage-users/)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During load tests we saw that uploading 1000 files into a folder caused a third of them to fail because the propagatien ran into stale NFS file handles. By delaying the propagation we can aggregate the updates to the root metadata to one write every 5sec (configurable). This takes a lot of pressure of the parent node.

It was never productized this because we never had the time to test this in kubernetes. We did that yesterday and it allowed all 1000 files to be uploaded without error.

That being said I saw several Missing parent ID on node as mentioned in https://github.com/owncloud/enterprise/issues/6690#issuecomment-2459106891

Looking into that right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never productized this because we never had the time to test this in kubernetes. We did that yesterday and it allowed all 1000 files to be uploaded without error.

Understood. Can we change the value for the oCIS product / oCIS Chart to hardcoded async in this case now? I'd like to keep the number of configurations permutations low. Same story as the async postprocessing back then...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micbar do you have an opinion on this?

Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCIS_DECOMPOSEDFS_PROPAGATOR=async will be considered experimental for the oCIS 7.0.0 release from what I understood in a call.

Therfore we cannot use it in the oCIS Helm chart and any production deployments.

@wkloucek wkloucek marked this pull request as draft November 7, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants