Merge pull request #205 from owncloud/skip-tests

updated skipped test
owncloud · Feb 27, 2024 · b7a8c3e · b7a8c3e
2 parents 48a9047 + 32e7e35
commit b7a8c3e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/tests/integration/Owncloud/OcisPhpSdk/OcisTest.php b/tests/integration/Owncloud/OcisPhpSdk/OcisTest.php
@@ -534,9 +534,6 @@ public function testGetGroupSort(OrderDirection $orderDirection, string $searchT
         $physicsLoversGroup = $ocis->createGroup("physicslovers", "physics lover group");
         $this->createdGroups = [$philosophyHatersGroup,$physicsLoversGroup];
         $groups = $ocis->getGroups(search: $searchText, orderBy: $orderDirection);
-        if(count($groups) <= 0) {
-            $this->markTestSkipped("no groups created");
-        }
         $this->assertCount(
             count($resultGroups),
             $groups,

diff --git a/tests/integration/Owncloud/OcisPhpSdk/ResourceInviteTest.php b/tests/integration/Owncloud/OcisPhpSdk/ResourceInviteTest.php
@@ -6,7 +6,7 @@
 
 use Owncloud\OcisPhpSdk\Drive;
 use Owncloud\OcisPhpSdk\Exception\BadRequestException;
-use Owncloud\OcisPhpSdk\Exception\ForbiddenException;
+use Owncloud\OcisPhpSdk\Exception\ConflictException;
 use Owncloud\OcisPhpSdk\Ocis;
 use Owncloud\OcisPhpSdk\OcisResource;
 use Owncloud\OcisPhpSdk\ShareReceived; // @phan-suppress-current-line PhanUnreferencedUseNormal it's used in a comment
@@ -142,18 +142,14 @@ public function testInviteGroup(): void
 
     public function testInviteSameUserAgain(): void
     {
-        $this->markTestSkipped('https://github.com/owncloud/ocis/issues/7842');
-        // @phpstan-ignore-next-line because the test is skipped
-        $this->expectException(ForbiddenException::class);
+        $this->expectException(ConflictException::class);
         $this->fileToShare->invite($this->einstein, $this->viewerRole);
         $this->fileToShare->invite($this->einstein, $this->viewerRole);
     }
 
     public function testInviteSameUserAgainWithDifferentRole(): void
     {
-        $this->markTestSkipped('https://github.com/owncloud/ocis/issues/7842');
-        // @phpstan-ignore-next-line because the test is skipped
-        $this->expectException(ForbiddenException::class);
+        $this->expectException(ConflictException::class);
         $this->fileToShare->invite($this->einstein, $this->viewerRole);
         $this->fileToShare->invite($this->einstein, $this->editorRole);
     }

diff --git a/tests/integration/Owncloud/OcisPhpSdk/ShareCreatedModifyTest.php b/tests/integration/Owncloud/OcisPhpSdk/ShareCreatedModifyTest.php
@@ -127,8 +127,6 @@ public function testDeleteGroupShare(): void
 
     public function testDeleteAnAlreadyDeletedShare(): void
     {
-        $this->markTestSkipped('https://github.com/owncloud/ocis/issues/7872');
-        // @phpstan-ignore-next-line because the test is skipped
         $this->expectException(NotFoundException::class);
         $this->fileToShare->invite($this->einstein, $this->viewerRole);
         $this->fileToShare->invite($this->marie, $this->viewerRole);
@@ -139,8 +137,6 @@ public function testDeleteAnAlreadyDeletedShare(): void
 
     public function testDeleteANotExistingShare(): void
     {
-        $this->markTestSkipped('https://github.com/owncloud/ocis/issues/7872');
-        // @phpstan-ignore-next-line because the test is skipped
         $this->expectException(NotFoundException::class);
         $permission = new Permission([
             'id' => 'does not exist'