Fixed an issue when the collaboration service registers apps also for…

[2403905]

… binary and unknown mime types.

Description

Related Issue

• Fixes #10086

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[jvillafanez]

Code looks fine, although I'm not sure why CI is failing.

[2403905]

@individual-it @SagarGi Is test.wopitest name can be changed across all tests or this is a predefined file name for the wopi API validator?

[individual-it]

I think it's only used here, so your change should everything that needs to be changed

[micbar]

The .wopitest is an extension for the validator, specially on ms 365

[individual-it]

Ci failure is unrelated and under investigation, see #10127

[individual-it]

I've added a QA-team label here, because I think it would be good to add some API test coverage for that to make sure the service only registers for the correct mime-types.
But feel free to merge before the tests are written, we can add them later

[micbar]

I fixed some return codes on the app/open endpoint.

We need to adapt the test expectations.

@ScharfViktor FYI

[ScharfViktor]

@ScharfViktor FYI

some tests return dowble response error:
"{ "code": "PERMISSION_DENIED", "message": "permission denied to create the file"}{ "code": "SERVER_ERROR", "message": "failed to create the file"}"

@2403905 will make fix it in reva

[micbar]

@2403905 Sorry, i missed a return 🙈

[micbar]

Please rebase

[saw-jan]

Activity tests were failing because, there're full name in displayName for some activities but not for some.
https://drone.owncloud.com/owncloud/ocis/39303/38/6
I have tried to fix the test expectation

Examples:

{
  "value": [
    {
      "template": {
        "message": "{user} added {resource} to {folder}",
        "variables": {
          "folder": {
            "name": "Alice Hansen"
          },
          "resource": {
            "name": "FOLDER"
          },
          "space": {
            "name": "Alice Hansen"
          },
          "user": {
            "displayName": "Alice"
          }
        }
      }
    },
    {
      "template": {
        "message": "{user} shared {resource} with {sharee}",
        "variables": {
          "folder": {
            "name": "Alice Hansen"
          },
          "resource": {
            "name": "FOLDER"
          },
          "sharee": {
            "displayName": "Brian"
          },
          "user": {
            "displayName": "Alice"
          }
        }
      }
    },
    {
      "template": {
        "message": "{user} added {resource} to {folder}",
        "variables": {
          "resource": {
            "name": "newfile.txt"
          },
          "space": {
            "name": "Alice Hansen"
          },
          "user": {
            "displayName": "Brian Murphy"
          }
        }
      }
    },
    {
      "template": {
        "message": "{user} updated {resource} in {folder}",
        "variables": {
          "resource": {
            "name": "newfile.txt"
          },
          "space": {
            "name": "Alice Hansen"
          },
          "user": {
            "displayName": "Brian Murphy"
          }
        }
      }
    },
    {
      "template": {
        "message": "{user} deleted {resource} from {folder}",
        "variables": {
          "resource": {
            "name": "newfile.txt"
          },
          "space": {
            "name": "Alice Hansen"
          },
          "user": {
            "displayName": "Brian"
          }
        }
      }
    }
  ]
}

{
      "template": {
        "message": "{user} added {resource} to {folder}",
        "variables": {
          "folder": {
            "name": "Alice Hansen"
          },
          "resource": {
            "name": "textfile.txt"
          },
          "space": {
            "name": "Alice Hansen"
          },
          "user": {
            "displayName": "Alice Hansen"
          }
        }
      }
    }

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud