Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Improve Ready and Health Checks #10163

Merged
merged 16 commits into from
Oct 14, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Sep 25, 2024

Description

  • Fixed the issue where ready and health checks were not functioning correctly.
  • Enhanced the checks to verify the readiness and health of individual services by evaluating their specific requirements.

Service Probes

Checklist moved to #10281

Questions

  • how to handle services that do not have a http endpoint

Related Issue

Motivation and Context

health and ready checks are essential to find out if a service is ready to serve requests. In the past, the checks were not functioning correctly. This release fixes the issue and enhances the checks to verify the readiness and health of individual services by evaluating their specific requirements.

How Has This Been Tested?

  • unit tests
  • local instance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Sep 25, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade fschade marked this pull request as draft September 29, 2024 09:18
@butonic
Copy link
Member

butonic commented Sep 30, 2024

related: #6774

@dragonchaser dragonchaser force-pushed the ready-health-checks branch 2 times, most recently from 746f19f to 956df08 Compare October 9, 2024 10:10
@dragonchaser dragonchaser mentioned this pull request Oct 10, 2024
@dragonchaser
Copy link
Member

We decided to split the issue into several PRs, this PR only contains 3 service healthchecks and basic skeletons & refactoring, the others will be implemented in follow-up PRs. (List see #10281 )

@dragonchaser dragonchaser force-pushed the ready-health-checks branch 2 times, most recently from 4b6505d to 6064386 Compare October 14, 2024 11:20
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Signed-off-by: Christian Richter <[email protected]>
Copy link

sonarcloud bot commented Oct 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.6% Duplication on New Code (required ≤ 50%)

See analysis details on SonarCloud

@dragonchaser dragonchaser merged commit 3d45d84 into owncloud:master Oct 14, 2024
2 of 3 checks passed
@butonic butonic deleted the ready-health-checks branch October 14, 2024 14:44
ownclouders pushed a commit that referenced this pull request Oct 14, 2024
Bugfix: Improve Ready and Health Checks
ownclouders pushed a commit that referenced this pull request Oct 15, 2024
Bugfix: Improve Ready and Health Checks
@micbar micbar mentioned this pull request Oct 21, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

healthcheck not failing even when service registration is not successful
4 participants