Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test coverage for sharing file with ocm #10565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nirajacharya2
Copy link
Contributor

Description

This PR adds test coverage for issue #10222

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Nov 14, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-first-share-lost branch 3 times, most recently from a67e608 to 8b0c0a3 Compare November 14, 2024 09:53
Copy link

sonarcloud bot commented Nov 14, 2024

@@ -611,3 +611,90 @@ Feature: an user shares resources using ScienceMesh application
}
}
"""

@issue-10222
Scenario: user lists permissions of a resource shared to a federated user
Copy link
Member

@saw-jan saw-jan Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: user lists permissions of a resource shared to a federated user
Scenario: local user lists multiple federation shares

Comment on lines +627 to +629
| shareType | user |
| permissionsRole | Viewer |
| federatedServer | @federation-ocis-server:10200 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to specifiy the federatedServer in table as it was not used in the requests but used only for logical purpose previously

Suggested change
| shareType | user |
| permissionsRole | Viewer |
| federatedServer | @federation-ocis-server:10200 |
| shareType | user |
| permissionsRole | Viewer |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants