Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for creating auth token for an app using cli #10660

Merged
merged 1 commit into from
Dec 24, 2024
Merged

[tests-only][full-ci] adding test for creating auth token for an app using cli #10660

merged 1 commit into from
Dec 24, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Nov 26, 2024 •
edited
Loading

Description

This PR adds test for creating access token using cli
https://owncloud.dev/services/auth-app/#via-cli-dev-only

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1: locally
  • test case 2: ci
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Nov 26, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Nov 26, 2024
Open
21 tasks
@nirajacharya2

This comment was marked as outdated.

Sign in to view
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci]add test for creating auth tocken for an app using cli [tests-only][full-ci]add test for creating auth token for an app using cli Nov 28, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token branch 2 times, most recently from ab849d2 to 2508f4d Compare December 2, 2024 08:58
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token branch 5 times, most recently from 782b119 to f677ad2 Compare December 11, 2024 07:00
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci]add test for creating auth token for an app using cli [tests-only][full-ci] addind test for creating auth token for an app using cli Dec 11, 2024
@nirajacharya2 nirajacharya2 marked this pull request as ready for review December 11, 2024 07:04
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token branch 2 times, most recently from b26d439 to e6ceea6 Compare December 11, 2024 08:24
@S-Panta S-Panta changed the title [tests-only][full-ci] addind test for creating auth token for an app using cli [tests-only][full-ci] adding test for creating auth token for an app using cli Dec 12, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token branch 4 times, most recently from 3c264f5 to 44fe8cb Compare December 16, 2024 05:44
@S-Panta
Copy link
Contributor

S-Panta commented Dec 18, 2024

LGTM

@nirajacharya2 nirajacharya2 force-pushed the test-auth-app-token branch 4 times, most recently from 0b83ced to c5b2dd8 Compare December 19, 2024 06:26
@nirajacharya2 nirajacharya2 mentioned this pull request Dec 23, 2024
Merged
9 tasks
saw-jan
saw-jan approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

amrita-shrestha
amrita-shrestha approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@S-Panta S-Panta merged commit d9bfdda into master Dec 24, 2024
4 checks passed
@S-Panta S-Panta deleted the test-auth-app-token branch December 24, 2024 06:23
ownclouders pushed a commit that referenced this pull request Dec 24, 2024
@S-Panta
Merge pull request #10660 from owncloud/test-auth-app-token
bb64c0d 
[tests-only][full-ci] adding test for creating auth token for an app using cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@S-Panta S-Panta Awaiting requested review from S-Panta

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @S-Panta @saw-jan @prashant-gurung899 @amrita-shrestha @PrajwolAmatya