Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Tests for sharing resource with Denied role in Personal and Project space #10696

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[tests-only][full-ci] Tests for sharing resource with Denied role in Personal and Project space #10696

merged 2 commits into from
Dec 17, 2024

Conversation

anon-pradip
Copy link
Contributor

@anon-pradip anon-pradip commented Dec 2, 2024 •
edited
Loading

Description

In this PR:

  • Added the "Denied" role to the list of additional permissions.
  • Updated methods to handle the "Denied" role and added assertions to check the presence or absence of shares based on the role.
  • Added new scenarios to validate the "Denied" role for both folders and files across Personal and Project spaces.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • CI
  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Dec 2, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@anon-pradip anon-pradip self-assigned this Dec 2, 2024
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch 2 times, most recently from d684dc2 to b356508 Compare December 2, 2024 06:32
@anon-pradip anon-pradip mentioned this pull request Dec 2, 2024
Open
7 tasks
@anon-pradip anon-pradip changed the title test: share with Denied role in Personal and Project space [tests-only][full-ci] Tests for sharing resource with Denied role in Personal and Project space Dec 2, 2024
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch 4 times, most recently from 6586d91 to 1243a18 Compare December 2, 2024 11:14
@anon-pradip anon-pradip marked this pull request as ready for review December 2, 2024 11:15
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch 2 times, most recently from e5c2350 to fec9ea4 Compare December 3, 2024 04:19
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch 3 times, most recently from eae19df to e313f05 Compare December 4, 2024 06:15
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from 0598b25 to fe63f58 Compare December 12, 2024 04:21
@anon-pradip anon-pradip requested a review from saw-jan December 12, 2024 04:22
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from fe63f58 to 77fbcb5 Compare December 12, 2024 07:18
@anon-pradip anon-pradip requested a review from saw-jan December 12, 2024 07:20
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from 77fbcb5 to 4fb6d85 Compare December 12, 2024 11:23
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from 4fb6d85 to c71fb6d Compare December 13, 2024 03:51
@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from c71fb6d to d395df7 Compare December 13, 2024 05:44
amrita-shrestha
amrita-shrestha approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Dec 16, 2024
Merged
Open
@saw-jan
Copy link
Member

saw-jan commented Dec 17, 2024

@anon-pradip Please, rebase your branch

@anon-pradip anon-pradip force-pushed the test/tests-for-new-sharing-role-DENIED branch from d395df7 to b690313 Compare December 17, 2024 04:24
@anon-pradip
Copy link
Contributor Author

@anon-pradip Please, rebase your branch

Done 👍

@anon-pradip anon-pradip requested a review from saw-jan December 17, 2024 04:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anon-pradip anon-pradip merged commit 4dd8d2e into master Dec 17, 2024
4 checks passed
@anon-pradip anon-pradip deleted the test/tests-for-new-sharing-role-DENIED branch December 17, 2024 05:43
ownclouders pushed a commit that referenced this pull request Dec 17, 2024
@anon-pradip
Merge pull request #10696 from owncloud/test/tests-for-new-sharing-ro…
1773561 
…le-DENIED

[tests-only][full-ci] Tests for sharing resource with Denied role in Personal and Project space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@saw-jan saw-jan saw-jan approved these changes

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@ishabaral ishabaral Awaiting requested review from ishabaral

Assignees

@anon-pradip anon-pradip

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anon-pradip @saw-jan @amrita-shrestha @S-Panta @PrajwolAmatya @nirajacharya2