[tests-only][full-ci] tests: adding test coverage for thumbnail service #10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirajacharya2
force-pushed
the
image-config-test
branch
3 times, most recently
from
8c65dfe to
d0d2152
Compare
nirajacharya2
requested review from
anon-pradip,
saw-jan,
prashant-gurung899,
amrita-shrestha and
S-Panta
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
4 tasks
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
nirajacharya2
force-pushed
the
image-config-test
branch
from
d0d2152 to
db38d55
Compare
nirajacharya2
force-pushed
the
image-config-test
branch
from
db38d55 to
b0702a9
Compare
saw-jan
reviewed
Dec 17, 2024
tests/acceptance/features/coreApiWebdavPreviews/previews.feature
Outdated
Show resolved
Hide resolved
nirajacharya2
force-pushed
the
image-config-test
branch
from
b0702a9 to
5f38b97
Compare
nirajacharya2
force-pushed
the
image-config-test
branch
2 times, most recently
from
0ca57bf to
5f02f38
Compare
saw-jan
reviewed
Dec 19, 2024
Comment on lines
+398
to
+399
| When user "Alice" downloads the preview of "/lorem-big.txt" with width "36" and height "36" and processor thumbnail using the WebDAV API | ||
| Then the HTTP status code should be "403" |
There was a problem hiding this comment.
what happens if we do not set the configs? 200?
There was a problem hiding this comment.
what happens if we do not set the configs? 200?
depends on the image. dose it exceed the default values for the configs?
| config | defaults |
|---|---|
| THUMBNAILS_MAX_INPUT_WIDTH | 7680 |
| THUMBNAILS_MAX_INPUT_HEIGHT | 7680 |
| THUMBNAILS_MAX_INPUT_IMAGE_FILE_SIZE | 50MB |
There was a problem hiding this comment.
Good. It is understandable for image file but for a text file, how does the thumbnail service react? if the text file is under max input size?
There was a problem hiding this comment.
its same as an image file. if the text file is under max input size a thumbnail is created
saw-jan
approved these changes
Dec 24, 2024
nirajacharya2
force-pushed
the
image-config-test
branch
2 times, most recently
from
b046446 to
1ef4a83
Compare
nirajacharya2
force-pushed
the
image-config-test
branch
2 times, most recently
from
167a0db to
a04bbdf
Compare
nirajacharya2
force-pushed
the
image-config-test
branch
from
a04bbdf to
6fd5630
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Dec 30, 2024
[tests-only][full-ci] tests: adding test coverage for thumbnail service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the image exceeded the any value in env
the server would return status code
500which shouldn't be the case as mentioned in #10589This PR adds test coverage for issue #10589. making sure the correct status code is returned.
Imp discussion : #10763 (comment)
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: