Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invitations README.md #5952

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Fix invitations README.md #5952

merged 3 commits into from
Mar 29, 2023

Conversation

mmattel
Copy link
Contributor

@mmattel mmattel commented Mar 29, 2023

References: #5700 and #5915

Due to an "accident" (no rebase, no push, force-push overwriting stuff), the readme in #5700 was messed up.

This PR:

  • fixes the readme.md file
  • adds and links the example json file
  • fixes some defaults as discussed and agreed with @ainmosni

Language review welcomed.

Post merging this, I can transport the content to the admin docs.

Not adding [docs-only] because I am changing the defaults to empty.

@update-docs
Copy link

update-docs bot commented Mar 29, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ainmosni
Copy link
Contributor

Can't approve, but LGTM.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit d02581e into master Mar 29, 2023
@delete-merged-branch delete-merged-branch bot deleted the update_invitations_readme branch March 29, 2023 11:44
ownclouders pushed a commit that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants