Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Add examples of more username combinations #6279

Merged
merged 1 commit into from
May 11, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 11, 2023

Description

Some test scenario examples in coreApiTrashbin/trashbinFilesFolders.feature used usernames that are just numbers: 123, -123, 0.0
Those examples were failing because a username like that cannot be created. So as part of PR #6270 those examples are being removed.

This PR adds some examples to createUser.feature for:

  • username with letters and numbers (works)
  • username with letters and dots (works)
  • username is only digits (cannot be created)
  • username is 0.0 (looks like a float) (cannot be created)

This will help "document" which usernames can and cannot be created in a default installation.

See doc issue owncloud/docs-ocis#495 - it seems that this is configurable with GRAPH_USERNAME_MATCH=none so the default behavior here is expected.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this May 11, 2023
@phil-davis phil-davis force-pushed the add-examples-for-usernames branch from 216114a to a687e6d Compare May 11, 2023 07:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 2f6f8fd into master May 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-examples-for-usernames branch May 11, 2023 08:44
ownclouders pushed a commit that referenced this pull request May 11, 2023
[tests-only] [full-ci] Add examples of more username combinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants