Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added cli test for changing password of non-existing user #9575

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[tests-only][full-ci] added cli test for changing password of non-existing user #9575

merged 1 commit into from
Jul 11, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Jul 10, 2024 •
edited
Loading

Description

Adding test scenario for changing password of non existing user via cli

Related Issue

How Has This Been Tested?

  • test environment:
  • locally and CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta mentioned this pull request Jul 10, 2024
Open
10 tasks
@S-Panta S-Panta force-pushed the ocis-cli-test-password-reset-non-user branch from 39d4b4a to f34386c Compare July 10, 2024 06:40
@S-Panta S-Panta marked this pull request as ready for review July 10, 2024 07:10
@S-Panta S-Panta force-pushed the ocis-cli-test-password-reset-non-user branch 2 times, most recently from 551a406 to 6583784 Compare July 10, 2024 10:11
@S-Panta S-Panta force-pushed the ocis-cli-test-password-reset-non-user branch from 6583784 to 3095d84 Compare July 11, 2024 03:55
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit ea1e80a into master Jul 11, 2024
4 checks passed
@saw-jan saw-jan deleted the ocis-cli-test-password-reset-non-user branch July 11, 2024 05:43
@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jul 11, 2024 •
edited
Loading

Resetting a password via cli is an admin feature. The most important case is to check that:

  • admin can change its own password.
  • admin after renaming its name can change its own password

I would create tests like this. And check that admin can create user after changing pass

I put this case to #9529

ownclouders pushed a commit that referenced this pull request Jul 11, 2024
@saw-jan
Merge pull request #9575 from owncloud/ocis-cli-test-password-reset-n…
40ee8bc 
…on-user

[tests-only][full-ci] added cli test for changing password of non-existing user
@saw-jan
Copy link
Member

saw-jan commented Jul 11, 2024

I put this case to #9529

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@saw-jan saw-jan saw-jan approved these changes

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S-Panta @ScharfViktor @saw-jan @nirajacharya2