Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] search: reindex command for spaces #9630

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[tests-only][full-ci] search: reindex command for spaces #9630

merged 1 commit into from
Jul 19, 2024

Conversation

ishabaral
Copy link
Contributor

Description

Adding test scenario for reindexing spaces via cli

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1: locally
  • test case 2: CI
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch 3 times, most recently from 52c4070 to 88b91cf Compare July 18, 2024 04:09
@ishabaral ishabaral self-assigned this Jul 18, 2024
@ishabaral ishabaral marked this pull request as ready for review July 18, 2024 04:58
saw-jan
saw-jan reviewed Jul 18, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could update to other methods where the return type is missing

tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch 2 times, most recently from be450ee to 279b97b Compare July 18, 2024 06:04
saw-jan
saw-jan requested changes Jul 18, 2024
View reviewed changes
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/CliContext.php Outdated Show resolved Hide resolved
@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch 4 times, most recently from 145fea9 to 3a2e604 Compare July 18, 2024 11:09
@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch from 3a2e604 to a5e120f Compare July 18, 2024 11:30
@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch from a5e120f to e2ad08b Compare July 19, 2024 04:22
@ishabaral ishabaral force-pushed the tests/cli_search_re-index_cmd_for_spaces branch from e2ad08b to a78d501 Compare July 19, 2024 04:30
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@saw-jan saw-jan merged commit d48cae6 into master Jul 19, 2024
4 checks passed
@saw-jan saw-jan deleted the tests/cli_search_re-index_cmd_for_spaces branch July 19, 2024 05:52
@ishabaral ishabaral mentioned this pull request Jul 19, 2024
Open
10 tasks
ownclouders pushed a commit that referenced this pull request Jul 19, 2024
@saw-jan
Merge pull request #9630 from owncloud/tests/cli_search_re-index_cmd_…
547a53f 
…for_spaces

[tests-only][full-ci] search: reindex command for spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor left review comments

@saw-jan saw-jan saw-jan approved these changes

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nabim777 nabim777 Awaiting requested review from nabim777

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

Assignees

@ishabaral ishabaral

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ishabaral @saw-jan @ScharfViktor