Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] adding test to remove old versions of files from a space using space-id using CLI #9639

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds test for removing versions of files from a specific space using space-id using CLI command

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the cli-remove-file-versions-by-spaceid branch from eefa71a to 426a38f Compare July 19, 2024 04:16
@prashant-gurung899
Copy link
Contributor Author

prashant-gurung899 commented Jul 19, 2024

@saw-jan In the test,instead of uploading only one file in the space and delete the versions of it, I have added few more steps to upload another file as well in the space so that we can know if it will delete all the versions of files from that space or not.

@prashant-gurung899 prashant-gurung899 force-pushed the cli-remove-file-versions-by-spaceid branch from 426a38f to 86e7382 Compare July 19, 2024 04:21
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review July 19, 2024 04:29
@prashant-gurung899 prashant-gurung899 force-pushed the cli-remove-file-versions-by-spaceid branch from 86e7382 to 01753b0 Compare July 19, 2024 05:47
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let use distinctive names for different files instead of appending numbers.

@prashant-gurung899 prashant-gurung899 force-pushed the cli-remove-file-versions-by-spaceid branch from cf70e45 to be7365e Compare July 19, 2024 06:37
@prashant-gurung899 prashant-gurung899 force-pushed the cli-remove-file-versions-by-spaceid branch from be7365e to 89ca45b Compare July 19, 2024 08:22
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Jul 19, 2024

@prashant-gurung899 prashant-gurung899 merged commit cea6533 into master Jul 19, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jul 19, 2024
…aceid

[tests-only][full-ci] adding test to remove old versions of files from a space using space-id using CLI
@prashant-gurung899 prashant-gurung899 deleted the cli-remove-file-versions-by-spaceid branch July 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants