Adjust to work with unit tests

owncloud · Nov 28, 2018 · 083f261 · 083f261
1 parent 442a6b9
commit 083f261
Show file tree

Hide file tree

Showing 10 changed files with 174 additions and 165 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,3 @@
-tests/clover.xml
 *.tar.gz
 build/
 

diff --git a/.travis.yml b/.travis.yml
@@ -25,8 +25,7 @@ script:
   - find . -name \*.php -exec php -l "{}" \;
 
   # Run phpunit tests
-  - phpunit --configuration phpunit.xml
-
+  - ../../lib/composer/bin/phpunit --configuration ./phpunit.xml
 after_success:
   - bash <(curl -s https://codecov.io/bash)
 

diff --git a/lib/appinfo/application.php b/lib/appinfo/application.php
@@ -29,73 +29,6 @@ public function __construct (array $urlParams = array()) {
 		$this->registerServices();
 	}
 
-	public function registerScripts() {
-		$container = $this->getContainer();
-
-		if ($this->isUserAllowedToUseCollabora()) {
-			$menuOption = $container->getServer()->getConfig()->getAppValue('richdocuments', 'menu_option');
-			if ($menuOption !== 'false') {
-				$navigationEntry = function () use ($container) {
-					return [
-						'id' => 'richdocuments_index',
-						'order' => 2,
-						'href' => $container->query('ServerContainer')->getURLGenerator()->linkToRoute('richdocuments.document.index'),
-						'icon' => $container->query('ServerContainer')->getURLGenerator()->imagePath('richdocuments', 'app.svg'),
-						'name' => $container->query('L10N')->t('Office')
-					];
-				};
-				$container->getServer()->getNavigationManager()->add($navigationEntry);
-			}
-
-			//Script for registering file actions
-			$container->getServer()->getEventDispatcher()->addListener(
-				'OCA\Files::loadAdditionalScripts',
-				function() {
-					\OCP\Util::addScript('richdocuments', 'viewer/viewer');
-					\OCP\Util::addStyle('richdocuments', 'viewer/odfviewer');
-				}
-			);
-
-			if (class_exists('\OC\Files\Type\TemplateManager')) {
-				$manager = \OC_Helper::getFileTemplateManager();
-
-				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.wordprocessingml.document', 'apps/richdocuments/assets/docxtemplate.docx');
-				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'apps/richdocuments/assets/xlsxtemplate.xlsx');
-				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.presentationml.presentation', 'apps/richdocuments/assets/pptxtemplate.pptx');
-			}
-		}
-
-		if ($this->publicLinksAllowedToUseCollabora()) {
-			\OCP\Util::connectHook(Share::class, "share_link_access", \OCA\Richdocuments\HookHandler::class, "addViewerScripts");
-		}
-	}
-
-	private function publicLinksAllowedToUseCollabora() {
-		// FIXME: some more rules? additional collabora flag?
-		return ($this->getContainer()->getServer()->getConfig()->getAppValue('core', 'shareapi_allow_links', 'yes') == 'yes');
-	}
-
-	private function isUserAllowedToUseCollabora() {
-		// no user -> no
-		$userSession = $this->getContainer()->getServer()->getUserSession();
-		if ($userSession === null || !$userSession->isLoggedIn()) {
-			return false;
-		}
-		// no group set -> all users are allowed
-		$groupName = $this->getContainer()->getServer()->getConfig()->getSystemValue('collabora_group', null);
-		if ($groupName === null) {
-			return true;
-		}
-		// group unknown -> error and allow nobody
-		$group = $this->getContainer()->getServer()->getGroupManager()->get($groupName);
-		if ($group === null) {
-			$this->getContainer()->getServer()->getLogger()->error("Group is unknown $groupName", ['app' => 'collabora']);
-			return false;
-		}
-
-		return $group->inGroup($userSession->getUser());
-	}
-
 	private function registerServices(){
 		$container = $this->getContainer();
 
@@ -162,4 +95,71 @@ private function registerServices(){
 			return $c->query('ServerContainer')->getMemCacheFactory();
 		});
 	}
+
+	public function registerScripts() {
+		$container = $this->getContainer();
+
+		if ($this->isUserAllowedToUseCollabora()) {
+			$menuOption = $container->getServer()->getConfig()->getAppValue('richdocuments', 'menu_option');
+			if ($menuOption !== 'false') {
+				$navigationEntry = function () use ($container) {
+					return [
+						'id' => 'richdocuments_index',
+						'order' => 2,
+						'href' => $container->query('ServerContainer')->getURLGenerator()->linkToRoute('richdocuments.document.index'),
+						'icon' => $container->query('ServerContainer')->getURLGenerator()->imagePath('richdocuments', 'app.svg'),
+						'name' => $container->query('L10N')->t('Office')
+					];
+				};
+				$container->getServer()->getNavigationManager()->add($navigationEntry);
+			}
+
+			//Script for registering file actions
+			$container->getServer()->getEventDispatcher()->addListener(
+				'OCA\Files::loadAdditionalScripts',
+				function() {
+					\OCP\Util::addScript('richdocuments', 'viewer/viewer');
+					\OCP\Util::addStyle('richdocuments', 'viewer/odfviewer');
+				}
+			);
+
+			if (class_exists('\OC\Files\Type\TemplateManager')) {
+				$manager = \OC_Helper::getFileTemplateManager();
+
+				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.wordprocessingml.document', 'apps/richdocuments/assets/docxtemplate.docx');
+				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.spreadsheetml.sheet', 'apps/richdocuments/assets/xlsxtemplate.xlsx');
+				$manager->registerTemplate('application/vnd.openxmlformats-officedocument.presentationml.presentation', 'apps/richdocuments/assets/pptxtemplate.pptx');
+			}
+		}
+
+		if ($this->publicLinksAllowedToUseCollabora()) {
+			\OCP\Util::connectHook(Share::class, "share_link_access", \OCA\Richdocuments\HookHandler::class, "addViewerScripts");
+		}
+	}
+
+	private function publicLinksAllowedToUseCollabora() {
+		// FIXME: some more rules? additional collabora flag?
+		return ($this->getContainer()->getServer()->getConfig()->getAppValue('core', 'shareapi_allow_links', 'yes') == 'yes');
+	}
+
+	private function isUserAllowedToUseCollabora() {
+		// no user -> no
+		$userSession = $this->getContainer()->getServer()->getUserSession();
+		if ($userSession === null || !$userSession->isLoggedIn()) {
+			return false;
+		}
+		// no group set -> all users are allowed
+		$groupName = $this->getContainer()->getServer()->getConfig()->getSystemValue('collabora_group', null);
+		if ($groupName === null) {
+			return true;
+		}
+		// group unknown -> error and allow nobody
+		$group = $this->getContainer()->getServer()->getGroupManager()->get($groupName);
+		if ($group === null) {
+			$this->getContainer()->getServer()->getLogger()->error("Group is unknown $groupName", ['app' => 'collabora']);
+			return false;
+		}
+
+		return $group->inGroup($userSession->getUser());
+	}
 }
diff --git a/controller/documentcontroller.php → lib/controller/documentcontroller.php b/controller/documentcontroller.php → lib/controller/documentcontroller.php
diff --git a/controller/settingscontroller.php → lib/controller/settingscontroller.php b/controller/settingscontroller.php → lib/controller/settingscontroller.php
diff --git a/phpunit.xml b/phpunit.xml
@@ -1,12 +1,13 @@
 <?xml version="1.0" encoding="utf-8" ?>
 <phpunit bootstrap="../../tests/bootstrap.php"
-		 verbose="true"  failOnWarning="true"
+		 verbose="true"
+		 failOnWarning="true"
 		 timeoutForSmallTests="900"
 		 timeoutForMediumTests="900"
 		 timeoutForLargeTests="900"
 		>
-	<testsuite name='phpunit'>
-		<directory suffix='test.php'>./tests</directory>
+	<testsuite name='unit'>
+		<directory suffix='test.php'>./tests/unit</directory>
 	</testsuite>
 	<!-- filters for code coverage -->
 	<filter>
@@ -15,6 +16,8 @@
 			<exclude>
 				<directory suffix=".php">./l10n</directory>
 				<directory suffix=".php">./tests</directory>
+				<directory suffix=".php">./templates</directory>
+				<directory suffix=".php">./appinfo</directory>
 			</exclude>
 		</whitelist>
 	</filter>

diff --git a/tests/bootstrap.php b/tests/bootstrap.php
diff --git a/tests/controller/documentcontrollertest.php b/tests/controller/documentcontrollertest.php
diff --git a/tests/appinfo/applicationtest.php → tests/unit/appinfo/applicationtest.php b/tests/appinfo/applicationtest.php → tests/unit/appinfo/applicationtest.php
@@ -8,16 +8,17 @@
  * This file is licensed under the Affero General Public License version 3 or
  * later.
  */
-namespace OCA\Richdocuments\AppInfo;
+namespace OCA\Richdocuments\Tests\unit;
 
-use OC_Hook;
+use \OC_Hook;
+use OCA\Richdocuments\AppInfo\Application;
 
 /**
  * Class ApplicationTest
  *
  * @group DB
  *
- * @package OCA\Richdocuments\AppInfo
+ * @package OCA\Richdocuments\Tests\Unit
  */
 class ApplicationTest extends \Test\TestCase {
 
@@ -101,6 +102,14 @@ public function testRegisterForPublicLinksAllowed() {
 		$this->assertArrayHasKey("share_link_access", $hooks["OCP\Share"]);
 	}
 
+	private function countListeners($name) {
+		$listeners = $this->app->getContainer()->getServer()->getEventDispatcher()->getListeners();
+		if (array_key_exists($name, $listeners)) {
+			return count($listeners[$name]);
+		}
+		return 0;
+	}
+
 	/**
 	 * Ensure that hook is not registered for viewer scripts if disallowed
 	 */
@@ -117,25 +126,25 @@ public function testRegisterForPublicLinksNotAllowed() {
 	 * Ensure viewer scripts are not registered for non-authenticated user
 	 */
 	public function testRegisterForUserAuthUnauthenticated() {
-		$listenersBefore = $this->app->getContainer()->getServer()->getEventDispatcher()->getListeners()['OCA\Files::loadAdditionalScripts'];
+		$listenersBefore = $this->countListeners('OCA\Files::loadAdditionalScripts');
 
 		$this->app->registerScripts();
 
-		$listenersAfter = $this->app->getContainer()->getServer()->getEventDispatcher()->getListeners()['OCA\Files::loadAdditionalScripts'];
-		$this->assertCount(count($listenersBefore), $listenersAfter);
+		$listenersAfter = $this->countListeners('OCA\Files::loadAdditionalScripts');
+		$this->assertEquals($listenersAfter, $listenersBefore);
 	}
 
 	/**
 	 * Ensure viewer scripts are registered for authenticated user when there are no collabora groups specified
 	 */
 	public function testRegisterForUserAuthAllowed() {
 		$this->setUpUser(false);
-		$listenersBefore = $this->app->getContainer()->getServer()->getEventDispatcher()->getListeners()['OCA\Files::loadAdditionalScripts'];
+		$listenersBefore = $this->countListeners('OCA\Files::loadAdditionalScripts');
 
 		$this->app->registerScripts();
 
-		$listenersAfter = $this->app->getContainer()->getServer()->getEventDispatcher()->getListeners()['OCA\Files::loadAdditionalScripts'];
-		$this->assertCount(count($listenersBefore)+1, $listenersAfter);
+		$listenersAfter = $this->countListeners('OCA\Files::loadAdditionalScripts');
+		$this->assertEquals($listenersAfter, $listenersBefore + 1);
 
 		$this->tearDownUser();
 	}