Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test_Only] Added acceptance test for single/multiple user:sync #506

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Feb 3, 2020

Description

Acceptance tests added for user:sync command covering:

  • defalt full users sync
  • sync a local user

Related Issue

owncloud/core#36597
owncloud/core#33293

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from codecov bot Feb 3, 2020
@kiranparajuli589 kiranparajuli589 changed the title Added acceptance test for single/multiple user:sync [Test_Only] Added acceptance test for single/multiple user:sync Feb 5, 2020
@kiranparajuli589
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/user_ldap/2208/93/6
Drone fails at install core because oracle is not up in some suites after available wait..

@phil-davis
Copy link
Contributor

@kiranparajuli589 user_ldap master has been updated with all the core suite-splitting that happened today.
Please rebase this PR.

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Feb 6, 2020

created a separate PR for super/sub-stringed users sync #508

@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #506 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #506   +/-   ##
=========================================
  Coverage     35.95%   35.95%           
  Complexity     1332     1332           
=========================================
  Files            31       31           
  Lines          3780     3780           
=========================================
  Hits           1359     1359           
  Misses         2421     2421           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bca6d...54735f9. Read the comment docs.

@phil-davis
Copy link
Contributor

@kiranparajuli589 please rebase - this repo will not let me merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants