-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] Added ldapAttributesForUserSearch in setConfig.sh #560
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff if CI passes.
Why does https://github.com/owncloud-docker/compose-playground/blob/master/compose/ldap/ldap.sh have a list of settings that have underscores, like It would be nice to understand this! |
@phil-davis Both naming convention is supported for occ commands. We can use either one! |
316c398
to
5bcc1ae
Compare
@phil-davis there was output-message change in https://github.com/owncloud/core/pull/37398/files#diff-0ada4aa7ff5e95845c939f25bf35448dL253-R277 |
38a6ec3
to
51e726a
Compare
@kiranparajuli589 What changed when you pushed again the last commit? |
yes, I know. I had pushed that a while ago. Maybe I made a small mistake - I just do not see how the newly-pushed commit is any different to what I originally pushed. Anyway, it does not matter - if it passes then it is good! |
https://drone.owncloud.com/owncloud/user_ldap/2536/48/11 https://drone.owncloud.com/owncloud/user_ldap/2536/53/11 |
Fixes owncloud/core#37428
Added
ldapAttributesForUserSearch
asuid
insidesetConfig.sh