Always return an int from Symfony Command execute method

lib/Command/CheckUser.php

@@ -76,25 +76,26 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		try {
 			$uid = $input->getArgument('ocName');
 			$this->isAllowed($input->getOption('force'));
 			$this->confirmUserIsMapped($uid);
 			$exists = $this->backend->userExists($uid);
 			if ($exists === true) {
 				$output->writeln('The user is still available on LDAP.');
-				return;
+				return 0;
 			}
 
-			$output->writeln('The user does not exists on LDAP anymore.');
+			$output->writeln('The user does not exist on LDAP anymore.');
 			$output->writeln('Clean up the user\'s remnants by: ./occ user:delete "'
 				. $uid . '"');
 		} catch (\Exception $e) {
 			$output->writeln('<error>' . $e->getMessage(). '</error>');
 		}
+		return 0;
 	}
 
 	/**

lib/Command/CreateEmptyConfig.php

@@ -65,9 +65,9 @@ protected function configure() {
 	/**
 	 * Executes the current command.
 	 *
-	 * @return null|int null or 0 if everything went fine, or an error code
+	 * @return int 0 if everything went fine, or an error code
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$configID = $input->getArgument('configID');
 		if ($configID === null) {
 			$configPrefix = $this->helper->nextPossibleConfigurationPrefix();

lib/Command/DeleteConfig.php

@@ -57,9 +57,9 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$configPrefix = $input->getArgument('configID');
 
 		$success = $this->helper->deleteServerConfiguration($configPrefix);
@@ -68,6 +68,8 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			$output->writeln("Deleted configuration with configID '{$configPrefix}'");
 		} else {
 			$output->writeln("Cannot delete configuration with configID '{$configPrefix}'");
+			return 1;
 		}
+		return 0;
 	}
 }

lib/Command/InvalidateCache.php

@@ -47,7 +47,7 @@ protected function configure() {
 			->setDescription('invalidates the LDAP cache');
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$uProxyBackendsCount = $this->uProxy->getBackendCount() + 1;  // +1 for the proxy itself
 		$gProxyBackendsCount = $this->gProxy->getBackendCount() + 1;  // +1 for the proxy itself
 

lib/Command/Search.php

@@ -103,9 +103,9 @@ protected function validateOffsetAndLimit($offset, $limit) {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$helper = new Helper();
 		$configPrefixes = $helper->getServerConfigurationPrefixes(true);
 		$ldapWrapper = new LDAP();
@@ -134,5 +134,6 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 			$line = $name . ($printID ? ' ('.$id.')' : '');
 			$output->writeln($line);
 		}
+		return 0;
 	}
 }

lib/Command/SetConfig.php

@@ -70,22 +70,23 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$helper = new Helper();
 		$availableConfigs = $helper->getServerConfigurationPrefixes();
 		$configID = $input->getArgument('configID');
 		if (!\in_array($configID, $availableConfigs)) {
 			$output->writeln("Invalid configID");
-			return;
+			return 1;
 		}
 
 		$this->setValue(
 			$configID,
 			$input->getArgument('configKey'),
 			$input->getArgument('configValue')
 		);
+		return 0;
 	}
 
 	/**

lib/Command/ShowConfig.php

@@ -75,21 +75,22 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$availableConfigs = $this->helper->getServerConfigurationPrefixes();
 		$configID = $input->getArgument('configID');
 		if ($configID !== null) {
 			$configIDs[] = $configID;
 			if (!\in_array($configIDs[0], $availableConfigs)) {
 				$output->writeln("Invalid configID");
-				return;
+				return 1;
 			}
 		} else {
 			$configIDs = $availableConfigs;
 		}
 		$this->renderConfigs($configIDs, $input, $output, $input->getOption('show-password'));
+		return 0;
 	}
 
 	/**

lib/Command/TestConfig.php

@@ -72,14 +72,14 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|void|null
+	 * @return int
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		$availableConfigs = $this->helper->getServerConfigurationPrefixes();
 		$configId = $input->getArgument('configID');
 		if (!\in_array($configId, $availableConfigs, true)) {
 			$output->writeln("Invalid configID");
-			return;
+			return 1;
 		}
 
 		$result = $this->testConfig($configId);
@@ -92,6 +92,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 		} else {
 			$output->writeln('Your LDAP server was kidnapped by aliens.');
 		}
+		return 0;
 	}
 
 	/**