feat: skip HTTP auth when connected via USB #104

mpldr · 2024-01-13T16:09:33Z

When connected via USB it doesn't make a whole lot of sense to ask for a password.

Signed-off-by: Moritz Poldrack <[email protected]>

owulveryck · 2024-01-13T20:03:46Z

Nice!

owulveryck · 2024-01-14T14:07:08Z

I had a deeper though about it.

I think we can leave it as a choice to the user.
People connecting only via USB should be able to combine the BIND_ADDRESS and the -unsafe option.

It is useful to people using both, and to be honest, the browser are querying only once.

What is the use case you are fulfilling with this feature?

mpldr · 2024-01-15T08:51:46Z

It's useful when starting the server once and then "forgetting" about it. My employers network does not allow for LAN (PC) to WIFI (remarkable) access, while most other networks do. Thus I am required to connect via USB. When connecting via WIFI however I want the authentication to be required.

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-01-24T06:32:46Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-02-13T11:01:35Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-03-17T20:09:36Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-05-18T06:34:41Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-24T13:27:36Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-24T13:32:53Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-24T13:36:09Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-24T13:42:55Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

golint: 93%

internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

ineffassign: 100%

license: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-26T13:07:00Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

github-actions

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

internal/eventhttphandler/gesture_handler.go
	Line 57: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)

golint: 93%

internal/remarkable/ip.go
	Line 10: warning: exported function HostsIP should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 14: warning: exported type SwipeDirection should have comment or be unexported (golint)
internal/eventhttphandler/gesture_handler.go
	Line 17: warning: exported const SwipeLeft should have comment (or a comment on this block) or be unexported (golint)

license: 100%

ineffassign: 100%

misspell: 100%

This report was generated using GoGitOps.

github-actions · 2024-12-26T13:26:09Z

internal/remarkable/ip.go

+	"strings"
+)
+
+func HostsIP(addr string) bool {


warning: exported function HostsIP should have comment or be unexported (golint)

feat: skip HTTP auth when connected via USB

ff031cc

Signed-off-by: Moritz Poldrack <[email protected]>

github-actions bot reviewed Jan 24, 2024

View reviewed changes

github-actions bot reviewed Feb 13, 2024

View reviewed changes

github-actions bot reviewed Mar 17, 2024

View reviewed changes

github-actions bot reviewed May 18, 2024

View reviewed changes

github-actions bot reviewed Dec 24, 2024

View reviewed changes

github-actions bot reviewed Dec 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: skip HTTP auth when connected via USB #104

feat: skip HTTP auth when connected via USB #104

mpldr commented Jan 13, 2024

owulveryck commented Jan 13, 2024

owulveryck commented Jan 14, 2024

mpldr commented Jan 15, 2024

github-actions bot left a comment

github-actions bot Jan 24, 2024

github-actions bot left a comment

github-actions bot Feb 13, 2024

github-actions bot left a comment

github-actions bot Mar 17, 2024

github-actions bot left a comment

github-actions bot May 18, 2024

github-actions bot left a comment

github-actions bot Dec 24, 2024

github-actions bot left a comment

github-actions bot Dec 24, 2024

github-actions bot left a comment

github-actions bot Dec 24, 2024

github-actions bot left a comment

github-actions bot Dec 24, 2024

github-actions bot left a comment

github-actions bot Dec 26, 2024

github-actions bot left a comment

github-actions bot Dec 26, 2024

feat: skip HTTP auth when connected via USB #104

Are you sure you want to change the base?

feat: skip HTTP auth when connected via USB #104

Conversation

mpldr commented Jan 13, 2024

owulveryck commented Jan 13, 2024

owulveryck commented Jan 14, 2024

mpldr commented Jan 15, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

golint: 93%

license: 100%

ineffassign: 100%

misspell: 100%

github-actions bot Jan 24, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

golint: 93%

license: 100%

ineffassign: 100%

misspell: 100%

github-actions bot Feb 13, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

golint: 93%

license: 100%

ineffassign: 100%

misspell: 100%

github-actions bot Mar 17, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

golint: 93%

license: 100%

ineffassign: 100%

misspell: 100%

github-actions bot May 18, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

GoGitOps Review

Grade: A+ (98.9%)

Files: 31

Issues: 2

gofmt: 100%

go_vet: 100%

gocyclo: 96%

golint: 93%

license: 100%

ineffassign: 100%