feat(linter): support overrides config field (#6974)

Part of #5653

apps/oxlint/fixtures/overrides/.oxlintrc.json

@@ -0,0 +1,26 @@
+{
+  "rules": {
+    "no-var": "error",
+    "no-console": "error"
+  },
+  "overrides": [
+    {
+      "files": ["*.js"],
+      "rules": {
+        "no-console": "warn"
+      }
+    },
+    {
+      "files": ["*.{js,jsx}"],
+      "rules": {
+        "no-console": "off"
+      }
+    },
+    {
+      "files": ["*.ts"],
+      "rules": {
+        "no-console": "warn"
+      }
+    }
+  ]
+}

apps/oxlint/fixtures/overrides/other.jsx

@@ -0,0 +1,2 @@
+var msg = "hello";
+console.log(msg);

apps/oxlint/fixtures/overrides/test.js

@@ -0,0 +1,2 @@
+var msg = "hello";
+console.log(msg);

apps/oxlint/fixtures/overrides/test.ts

@@ -0,0 +1,2 @@
+var msg = "hello";
+console.log(msg);

apps/oxlint/src/lint.rs

@@ -629,4 +629,25 @@ mod test {
             std::fs::read_to_string("fixtures/print_config/ban_rules/expect.json").unwrap();
         assert_eq!(config, expect_json.trim());
     }
+
+    #[test]
+    fn test_overrides() {
+        let result =
+            test(&["-c", "fixtures/overrides/.oxlintrc.json", "fixtures/overrides/test.js"]);
+        assert_eq!(result.number_of_files, 1);
+        assert_eq!(result.number_of_warnings, 0);
+        assert_eq!(result.number_of_errors, 1);
+
+        let result =
+            test(&["-c", "fixtures/overrides/.oxlintrc.json", "fixtures/overrides/test.ts"]);
+        assert_eq!(result.number_of_files, 1);
+        assert_eq!(result.number_of_warnings, 1);
+        assert_eq!(result.number_of_errors, 1);
+
+        let result =
+            test(&["-c", "fixtures/overrides/.oxlintrc.json", "fixtures/overrides/other.jsx"]);
+        assert_eq!(result.number_of_files, 1);
+        assert_eq!(result.number_of_warnings, 0);
+        assert_eq!(result.number_of_errors, 1);
+    }
 }

crates/oxc_diagnostics/src/lib.rs

@@ -97,6 +97,7 @@ pub struct OxcCode {
     pub scope: Option<Cow<'static, str>>,
     pub number: Option<Cow<'static, str>>,
 }
+
 impl OxcCode {
     pub fn is_some(&self) -> bool {
         self.scope.is_some() || self.number.is_some()

crates/oxc_linter/Cargo.toml

@@ -26,27 +26,28 @@ oxc_cfg = { workspace = true }
 oxc_codegen = { workspace = true }
 oxc_diagnostics = { workspace = true }
 oxc_ecmascript = { workspace = true }
-oxc_index = { workspace = true }
+oxc_index = { workspace = true, features = ["serialize"] }
 oxc_macros = { workspace = true }
 oxc_parser = { workspace = true }
 oxc_regular_expression = { workspace = true }
 oxc_resolver = { workspace = true }
 oxc_semantic = { workspace = true }
 oxc_span = { workspace = true, features = ["schemars", "serialize"] }
-oxc_syntax = { workspace = true }
+oxc_syntax = { workspace = true, features = ["serialize"] }
 
 aho-corasick = { workspace = true }
 bitflags = { workspace = true }
 convert_case = { workspace = true }
 cow-utils = { workspace = true }
 dashmap = { workspace = true }
-globset = { workspace = true }
+globset = { workspace = true, features = ["serde1"] }
 itertools = { workspace = true }
 json-strip-comments = { workspace = true }
 language-tags = { workspace = true }
 lazy_static = { workspace = true }
 memchr = { workspace = true }
 mime_guess = { workspace = true }
+nonmax = { workspace = true }
 once_cell = { workspace = true }
 phf = { workspace = true, features = ["macros"] }
 rayon = { workspace = true }

crates/oxc_linter/src/builder.rs

@@ -7,7 +7,7 @@ use oxc_span::CompactStr;
 use rustc_hash::FxHashSet;
 
 use crate::{
-    config::{ESLintRule, LintPlugins, OxlintRules},
+    config::{ConfigStore, ESLintRule, LintPlugins, OxlintOverrides, OxlintRules},
     rules::RULES,
     AllowWarnDeny, FixKind, FrameworkFlags, LintConfig, LintFilter, LintFilterKind, LintOptions,
     Linter, Oxlintrc, RuleCategory, RuleEnum, RuleWithSeverity,
@@ -18,6 +18,7 @@ pub struct LinterBuilder {
     pub(super) rules: FxHashSet<RuleWithSeverity>,
     options: LintOptions,
     config: LintConfig,
+    overrides: OxlintOverrides,
     cache: RulesCache,
 }
 
@@ -36,9 +37,10 @@ impl LinterBuilder {
         let options = LintOptions::default();
         let config = LintConfig::default();
         let rules = FxHashSet::default();
+        let overrides = OxlintOverrides::default();
         let cache = RulesCache::new(config.plugins);
 
-        Self { rules, options, config, cache }
+        Self { rules, options, config, overrides, cache }
     }
 
     /// Warn on all rules in all plugins and categories, including those in `nursery`.
@@ -48,6 +50,7 @@ impl LinterBuilder {
     pub fn all() -> Self {
         let options = LintOptions::default();
         let config = LintConfig { plugins: LintPlugins::all(), ..LintConfig::default() };
+        let overrides = OxlintOverrides::default();
         let cache = RulesCache::new(config.plugins);
         Self {
             rules: RULES
@@ -56,6 +59,7 @@ impl LinterBuilder {
                 .collect(),
             options,
             config,
+            overrides,
             cache,
         }
     }
@@ -82,15 +86,22 @@ impl LinterBuilder {
     /// match any recognized rules.
     pub fn from_oxlintrc(start_empty: bool, oxlintrc: Oxlintrc) -> Self {
         // TODO: monorepo config merging, plugin-based extends, etc.
-        let Oxlintrc { plugins, settings, env, globals, categories, rules: oxlintrc_rules } =
-            oxlintrc;
+        let Oxlintrc {
+            plugins,
+            settings,
+            env,
+            globals,
+            categories,
+            rules: oxlintrc_rules,
+            overrides,
+        } = oxlintrc;
 
         let config = LintConfig { plugins, settings, env, globals };
         let options = LintOptions::default();
         let rules =
             if start_empty { FxHashSet::default() } else { Self::warn_correctness(plugins) };
         let cache = RulesCache::new(config.plugins);
-        let mut builder = Self { rules, options, config, cache };
+        let mut builder = Self { rules, options, config, overrides, cache };
 
         if !categories.is_empty() {
             builder = builder.with_filters(categories.filters());
@@ -240,7 +251,8 @@ impl LinterBuilder {
             self.rules.into_iter().collect::<Vec<_>>()
         };
         rules.sort_unstable_by_key(|r| r.id());
-        Linter::new(rules, self.options, self.config)
+        let config = ConfigStore::new(rules, self.config, self.overrides);
+        Linter::new(self.options, config)
     }
 
     /// Warn for all correctness rules in the given set of plugins.
@@ -564,7 +576,7 @@ mod test {
         desired_plugins.set(LintPlugins::TYPESCRIPT, false);
 
         let linter = LinterBuilder::default().with_plugins(desired_plugins).build();
-        for rule in linter.rules() {
+        for rule in linter.rules().iter() {
             let name = rule.name();
             let plugin = rule.plugin_name();
             assert_ne!(